From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 11/20] [POWERPC] Wire up PCI on Bamboo board
Date: Thu, 20 Dec 2007 07:26:07 +1100 [thread overview]
Message-ID: <1198095967.18908.33.camel@pasglop> (raw)
In-Reply-To: <47691DE6.8050901@ru.mvista.com>
On Wed, 2007-12-19 at 16:34 +0300, Valentine Barshak wrote:
> > --- linux-work.orig/arch/powerpc/boot/dts/bamboo.dts 2007-12-10 15:56:59.000000000 +1100
> > +++ linux-work/arch/powerpc/boot/dts/bamboo.dts 2007-12-10 16:39:51.000000000 +1100
> > @@ -239,10 +239,48 @@
> > zmii-channel = <1>;
> > };
> > };
> > +
> > + PCI0: pci@ec000000 {
> > + device_type = "pci";
> > + #interrupt-cells = <1>;
> > + #size-cells = <2>;
> > + #address-cells = <3>;
> > + compatible = "ibm,plb440ep-pci", "ibm,plb-pci";
> > + primary;
> > + reg = <0 eec00000 8 /* Config space access */
> > + 0 eed80000 4 /* IACK */
> > + 0 eed80000 4 /* Special cycle */
> > + 0 ef480000 40>; /* Internal registers */
>
> Why ef480000 here? IIRC, the docs say it should be ef400000, while
> ef400040 - ef4fffff are reserved and can mirror local registers.
Dunno... probably a typo, though it worked :-) I'll fix it up.
Ben.
next prev parent reply other threads:[~2007-12-19 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 7:38 [PATCH 11/20] [POWERPC] Wire up PCI on Bamboo board Benjamin Herrenschmidt
2007-12-19 13:34 ` Valentine Barshak
2007-12-19 20:26 ` Benjamin Herrenschmidt [this message]
2007-12-20 20:26 ` Valentine Barshak
2007-12-20 20:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198095967.18908.33.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).