From: Daniel Walker <dwalker@mvista.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: matthias.kaehlcke@gmail.com, linux-kernel@vger.kernel.org,
linux@bohmer.net, linuxppc-dev@ozlabs.org, mingo@elte.hu,
kjwinchester@gmail.com
Subject: Re: [PATCH 1/3] ps3: vuart: fix error path locking
Date: Thu, 20 Dec 2007 12:13:49 -0800 [thread overview]
Message-ID: <1198181630.10713.11.camel@imap.mvista.com> (raw)
In-Reply-To: <20071220120635.d66550bd.akpm@linux-foundation.org>
On Thu, 2007-12-20 at 12:06 -0800, Andrew Morton wrote:
> On Thu, 20 Dec 2007 11:32:25 -0800 Daniel Walker <dwalker@mvista.com> wrote:
>
> > On Tue, 2007-12-18 at 19:04 -0800, Geoff Levand wrote:
> >
> > > Unfortunately there wasn't enough context in the patch to see
> > > that there is a down() earlier in the routine, and that the patch
> > > does indeed remove an incorrectly placed down(). Here is the
> > > entire routine, marked with what the patch removes.
> > >
> >
> > Andrew have you had a chance to review this?
> >
>
> Confused. I did review it: http://lkml.org/lkml/2007/12/18/384
Yeah, but Geoff countered http://lkml.org/lkml/2007/12/18/409
Do you still think the patch is wrong, given the whole function?
Daniel
prev parent reply other threads:[~2007-12-20 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071213003023.117964080@mvista.com>
2007-12-12 8:00 ` [PATCH 1/3] ps3: vuart: fix error path locking Daniel Walker
2007-12-13 2:00 ` Geoff Levand
2007-12-19 1:10 ` Andrew Morton
2007-12-19 1:54 ` Daniel Walker
2007-12-19 3:04 ` Geoff Levand
2007-12-20 19:32 ` Daniel Walker
2007-12-20 20:06 ` Andrew Morton
2007-12-20 20:13 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198181630.10713.11.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@bohmer.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthias.kaehlcke@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).