* [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
@ 2007-12-21 4:39 Benjamin Herrenschmidt
2007-12-21 12:09 ` Josh Boyer
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2007-12-21 4:39 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev
This removes a bogus empty "ranges" property in the EBC device node
of the Bamboo board device-tree.
The "ranges" property will be created by the boot wrapper, there is
no need to have an empty property there, and that causes recent
dtc to complain.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
arch/powerpc/boot/dts/bamboo.dts | 1 -
1 file changed, 1 deletion(-)
--- linux-merge.orig/arch/powerpc/boot/dts/bamboo.dts 2007-12-21 14:35:23.000000000 +1100
+++ linux-merge/arch/powerpc/boot/dts/bamboo.dts 2007-12-21 14:35:25.000000000 +1100
@@ -126,7 +126,6 @@
#address-cells = <2>;
#size-cells = <1>;
clock-frequency = <0>; /* Filled in by zImage */
- ranges;
interrupts = <5 1>;
interrupt-parent = <&UIC1>;
};
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
2007-12-21 4:39 [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node Benjamin Herrenschmidt
@ 2007-12-21 12:09 ` Josh Boyer
2007-12-21 21:16 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Josh Boyer @ 2007-12-21 12:09 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
On Fri, 21 Dec 2007 15:39:35 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> This removes a bogus empty "ranges" property in the EBC device node
> of the Bamboo board device-tree.
>
> The "ranges" property will be created by the boot wrapper, there is
> no need to have an empty property there, and that causes recent
> dtc to complain.
The wrapper doesn't do anything with EBC for bamboo because the EBC
stuff is a nightmare on this board. The patch can stand, but I'll
fixup the comments in the changelog.
josh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
2007-12-21 12:09 ` Josh Boyer
@ 2007-12-21 21:16 ` Benjamin Herrenschmidt
2007-12-21 22:08 ` Josh Boyer
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2007-12-21 21:16 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev
On Fri, 2007-12-21 at 06:09 -0600, Josh Boyer wrote:
> On Fri, 21 Dec 2007 15:39:35 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > This removes a bogus empty "ranges" property in the EBC device node
> > of the Bamboo board device-tree.
> >
> > The "ranges" property will be created by the boot wrapper, there is
> > no need to have an empty property there, and that causes recent
> > dtc to complain.
>
> The wrapper doesn't do anything with EBC for bamboo because the EBC
> stuff is a nightmare on this board. The patch can stand, but I'll
> fixup the comments in the changelog.
The wrapper could still create ranges for the chip select settings no ?
In any case, empty "ranges" is bogus.
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node
2007-12-21 21:16 ` Benjamin Herrenschmidt
@ 2007-12-21 22:08 ` Josh Boyer
0 siblings, 0 replies; 4+ messages in thread
From: Josh Boyer @ 2007-12-21 22:08 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev
On Sat, 22 Dec 2007 08:16:55 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> On Fri, 2007-12-21 at 06:09 -0600, Josh Boyer wrote:
> > On Fri, 21 Dec 2007 15:39:35 +1100
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > This removes a bogus empty "ranges" property in the EBC device node
> > > of the Bamboo board device-tree.
> > >
> > > The "ranges" property will be created by the boot wrapper, there is
> > > no need to have an empty property there, and that causes recent
> > > dtc to complain.
> >
> > The wrapper doesn't do anything with EBC for bamboo because the EBC
> > stuff is a nightmare on this board. The patch can stand, but I'll
> > fixup the comments in the changelog.
>
> The wrapper could still create ranges for the chip select settings no ?
It could. It doesn't though. Perhaps our interpretation of "will be
created" differed.
> In any case, empty "ranges" is bogus.
Correct. Which is why I said I'd just edit the changelog :).
josh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-21 22:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-21 4:39 [PATCH 18/21] [POWERPC] bamboo: remove bogus "ranges" property in EBC node Benjamin Herrenschmidt
2007-12-21 12:09 ` Josh Boyer
2007-12-21 21:16 ` Benjamin Herrenschmidt
2007-12-21 22:08 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).