* [PATCH] Add information on enabling sound on the MPC8641 HPCN
@ 2007-12-23 3:35 Timur Tabi
2007-12-23 15:26 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Timur Tabi @ 2007-12-23 3:35 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Timur Tabi
Add a comment to the DTS file for the MPC8641 HPCN describing a wiring change
needed to get sound working on this board.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
For a two-line comment, I thought the DTS would be the best place to put this
information.
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index 86fc228..08f78a6 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -7,6 +7,9 @@
* under the terms of the GNU General Public License as published by the
* Free Software Foundation; either version 2 of the License, or (at your
* option) any later version.
+ *
+ * On some revisions of this board, C29 of the Uli M1575 must be connected
+ * to ground (e.g. ground of resistor R353) in order to enable sound.
*/
--
1.5.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Add information on enabling sound on the MPC8641 HPCN
2007-12-23 3:35 [PATCH] Add information on enabling sound on the MPC8641 HPCN Timur Tabi
@ 2007-12-23 15:26 ` Olof Johansson
2007-12-24 17:24 ` Timur Tabi
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2007-12-23 15:26 UTC (permalink / raw)
To: Timur Tabi; +Cc: linuxppc-dev
On Sat, Dec 22, 2007 at 09:35:44PM -0600, Timur Tabi wrote:
> Add a comment to the DTS file for the MPC8641 HPCN describing a wiring change
> needed to get sound working on this board.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> For a two-line comment, I thought the DTS would be the best place to put this
> information.
Sounds like a board rework document on your support site is the right
place for this. We normally don't document board reworks required in
the linux sources, do we?
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add information on enabling sound on the MPC8641 HPCN
2007-12-23 15:26 ` Olof Johansson
@ 2007-12-24 17:24 ` Timur Tabi
2007-12-24 23:10 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Timur Tabi @ 2007-12-24 17:24 UTC (permalink / raw)
To: Olof Johansson; +Cc: linuxppc-dev
Olof Johansson wrote:
> Sounds like a board rework document on your support site is the right
> place for this.
Except that no one would know to look there. I don't even know who to
contact to get that kind of information on that site.
> We normally don't document board reworks required in
> the linux sources, do we?
I do, if I can find a discrete place for it. The patch for my QE UART
driver has a similar comment in the DTS for the 8323E MDS.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add information on enabling sound on the MPC8641 HPCN
2007-12-24 17:24 ` Timur Tabi
@ 2007-12-24 23:10 ` Olof Johansson
2007-12-25 20:42 ` Timur Tabi
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2007-12-24 23:10 UTC (permalink / raw)
To: Timur Tabi; +Cc: linuxppc-dev
On Mon, Dec 24, 2007 at 11:24:19AM -0600, Timur Tabi wrote:
> Olof Johansson wrote:
>
> > Sounds like a board rework document on your support site is the right
> > place for this.
>
> Except that no one would know to look there.
Why do you expect people to look at the device tree source file instead?
It seems even more remote to me.
> I don't even know who to contact to get that kind of information on
> that site.
That's a pretty lame excuse. :)
> > We normally don't document board reworks required in
> > the linux sources, do we?
>
> I do, if I can find a discrete place for it. The patch for my QE UART
> driver has a similar comment in the DTS for the 8323E MDS.
Are freescale customers really used to going to the linux device tree
sources to find out how to modify their boards to achieve certain
functionality with their eval boards?! I guess you guys are taking the
"device trees are used to describe the hardware" statement to it's
fullest extent.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add information on enabling sound on the MPC8641 HPCN
2007-12-24 23:10 ` Olof Johansson
@ 2007-12-25 20:42 ` Timur Tabi
2007-12-26 2:18 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Timur Tabi @ 2007-12-25 20:42 UTC (permalink / raw)
To: Olof Johansson; +Cc: linuxppc-dev
Olof Johansson wrote:
> Are freescale customers really used to going to the linux device tree
> sources to find out how to modify their boards to achieve certain
> functionality with their eval boards?! I guess you guys are taking the
> "device trees are used to describe the hardware" statement to it's
> fullest extent.
Well, I've always been a rebel.
Honestly, I just thought it would be harmless and a lot easier (for me)
than trying to convince some documentation dude to write it up and
publish it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add information on enabling sound on the MPC8641 HPCN
2007-12-25 20:42 ` Timur Tabi
@ 2007-12-26 2:18 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2007-12-26 2:18 UTC (permalink / raw)
To: Timur Tabi; +Cc: linuxppc-dev
On Tue, Dec 25, 2007 at 02:42:34PM -0600, Timur Tabi wrote:
> Olof Johansson wrote:
>
>> Are freescale customers really used to going to the linux device tree
>> sources to find out how to modify their boards to achieve certain
>> functionality with their eval boards?! I guess you guys are taking the
>> "device trees are used to describe the hardware" statement to it's
>> fullest extent.
>
> Well, I've always been a rebel.
>
> Honestly, I just thought it would be harmless and a lot easier (for me)
> than trying to convince some documentation dude to write it up and publish
> it.
Heh. Well, it's up to Kumar what to do about this one upstream, it
just seemed like a weird choice to document board reworks in the device
tree comments.
Having it somewhere that sticks to google's database is better than
nothing at all, I suppose. :)
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-12-26 2:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-23 3:35 [PATCH] Add information on enabling sound on the MPC8641 HPCN Timur Tabi
2007-12-23 15:26 ` Olof Johansson
2007-12-24 17:24 ` Timur Tabi
2007-12-24 23:10 ` Olof Johansson
2007-12-25 20:42 ` Timur Tabi
2007-12-26 2:18 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).