linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers
Date: Sat, 05 Jan 2008 21:19:48 +1100	[thread overview]
Message-ID: <1199528388.7291.55.camel@pasglop> (raw)
In-Reply-To: <1199526609-12290-1-git-send-email-sr@denx.de>


On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote:
> Performance tests done by AMCC have shown that 256 buffer increase the
> performance of the Linux EMAC driver. So let's update the default
> values to match this setup.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---

Do we have the numbers ? Did they also measure latency ?

Ben.

>  drivers/net/ibm_newemac/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ibm_newemac/Kconfig b/drivers/net/ibm_newemac/Kconfig
> index 0d3e738..5a06727 100644
> --- a/drivers/net/ibm_newemac/Kconfig
> +++ b/drivers/net/ibm_newemac/Kconfig
> @@ -9,12 +9,12 @@ config IBM_NEW_EMAC
>  config IBM_NEW_EMAC_RXB
>  	int "Number of receive buffers"
>  	depends on IBM_NEW_EMAC
> -	default "128"
> +	default "256"
>  
>  config IBM_NEW_EMAC_TXB
>  	int "Number of transmit buffers"
>  	depends on IBM_NEW_EMAC
> -	default "64"
> +	default "256"
>  
>  config IBM_NEW_EMAC_POLL_WEIGHT
>  	int "MAL NAPI polling weight"

  reply	other threads:[~2008-01-05 10:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05  9:50 [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers Stefan Roese
2008-01-05 10:19 ` Benjamin Herrenschmidt [this message]
2008-01-05 12:38   ` Stefan Roese
2008-01-05 20:53     ` Benjamin Herrenschmidt
2008-01-05 21:48       ` Josh Boyer
2008-01-05 21:54         ` Benjamin Herrenschmidt
2008-01-06  1:43           ` Josh Boyer
2008-01-11 17:48     ` Eugene Surovegin
2008-01-11 22:10       ` Benjamin Herrenschmidt
2008-01-12  7:26         ` Stefan Roese
2008-01-12  7:57           ` Benjamin Herrenschmidt
2008-01-12  9:08             ` Eugene Surovegin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199528388.7291.55.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).