linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] nand base: Don't panic if a controller driver does ecc its own way.
@ 2007-12-13 17:15 Scott Wood
  2007-12-13 17:15 ` [PATCH 2/4] nand base: Give drivers a chance to do late initialization Scott Wood
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Scott Wood @ 2007-12-13 17:15 UTC (permalink / raw)
  To: dwmw2; +Cc: linuxppc-dev, linux-mtd

Some hardware, such as the enhanced local bus controller used on some
mpc83xx chips, does ecc transparently when reading and writing data, rather
than providing a generic calculate/correct mechanism that can be exported to
the nand subsystem.

The subsystem should not BUG() when calculate, correct, or hwctl are
missing, if the methods that call them have been overridden.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 drivers/mtd/nand/nand_base.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index e29c1da..85a7283 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2469,8 +2469,12 @@ int nand_scan_tail(struct mtd_info *mtd)
 			chip->ecc.write_oob = nand_write_oob_std;
 
 	case NAND_ECC_HW_SYNDROME:
-		if (!chip->ecc.calculate || !chip->ecc.correct ||
-		    !chip->ecc.hwctl) {
+		if ((!chip->ecc.calculate || !chip->ecc.correct ||
+		     !chip->ecc.hwctl) &&
+		    (!chip->ecc.read_page ||
+		     chip->ecc.read_page == nand_read_page_hwecc) ||
+		     !chip->ecc.write_page ||
+		     chip->ecc.write_page == nand_write_page_hwecc) {
 			printk(KERN_WARNING "No ECC functions supplied, "
 			       "Hardware ECC not possible\n");
 			BUG();
-- 
1.5.3.7

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2008-01-08 17:50 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-13 17:15 [PATCH 1/4] nand base: Don't panic if a controller driver does ecc its own way Scott Wood
2007-12-13 17:15 ` [PATCH 2/4] nand base: Give drivers a chance to do late initialization Scott Wood
2008-01-08  7:57   ` David Woodhouse
2008-01-08 17:48     ` Scott Wood
2007-12-13 17:15 ` [PATCH 3/4] mtd: Factor out OF partition support from the NOR driver Scott Wood
2008-01-08  7:45   ` Stefan Roese
2008-01-08  8:10   ` David Woodhouse
2007-12-13 17:15 ` [PATCH 4/4] MPC8313 enhanced Local Bus Controller NAND support Scott Wood
2007-12-14  5:14   ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).