linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: [PATCH] Miscellaneous for Taco
Date: Wed, 09 Jan 2008 07:41:13 +1100	[thread overview]
Message-ID: <1199824873.6734.51.camel@pasglop> (raw)
In-Reply-To: <200801082023.11475.sr@denx.de>


On Tue, 2008-01-08 at 20:23 +0100, Stefan Roese wrote:
> On Tuesday 08 January 2008, Sean MacLennan wrote:
> > How about just 44x?
> >
> > Cheers,
> >     Sean
> >
> > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> > index 7580aa5..682deae 100644
> > --- a/drivers/usb/Kconfig
> > +++ b/drivers/usb/Kconfig
> > @@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI
> >         # PPC:
> >         default y if STB03xxx
> >         default y if PPC_MPC52xx
> > +       default y if 44x
> 
> No. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. 
> But since your patch only touches 440EP, you should just enable OHCI for 
> exactly this platform.

Note that the above Kconfig stuff just enabling the choice to enable
OHCI, it's not enabling build of OHCI per-se.

Ben.

  reply	other threads:[~2008-01-08 20:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05  5:21 [PATCH] Miscellaneous for Taco Sean MacLennan
2008-01-05  7:24 ` Benjamin Herrenschmidt
2008-01-05  9:26   ` Stefan Roese
2008-01-05 18:22     ` Sean MacLennan
2008-01-05 20:56       ` Benjamin Herrenschmidt
2008-01-08 18:41         ` Sean MacLennan
2008-01-08 19:23           ` Stefan Roese
2008-01-08 20:41             ` Benjamin Herrenschmidt [this message]
2008-01-09 17:26             ` Sean MacLennan
2008-01-09 19:18               ` Josh Boyer
2008-01-09 19:26                 ` Sean MacLennan
2008-01-09 19:54                   ` Josh Boyer
2008-01-09 20:10                     ` Sean MacLennan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199824873.6734.51.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=smaclennan@pikatech.com \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).