From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <1189748800.165997.810365539433.2.gpush@pokey> References: <1189748800.165997.810365539433.2.gpush@pokey> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <11C5F6D9-7520-4DEE-A061-648A377DCB6D@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH 2/2] fsl/embedded6xx: don't cast the result of of_get_property Date: Tue, 25 Sep 2007 15:27:30 -0500 To: Jeremy Kerr Cc: PowerPC dev list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sep 14, 2007, at 12:46 AM, Jeremy Kerr wrote: > Use a temporary variable of the correct type instead. > > Also, this allows us to check the return value in ls_uarts_init, to > avoid dereferencing a null pointer if required properties aren't > present. > > Signed-off-by: Jeremy Kerr Can I get you to respin this against for-2.6.24. For some reason this doesn't apply cleanly for me. - k