From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 406WQp08dlzF0mt for ; Fri, 23 Mar 2018 02:52:49 +1100 (AEDT) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2MFodus057861 for ; Thu, 22 Mar 2018 11:52:47 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gveuhjgne-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Thu, 22 Mar 2018 11:52:46 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Mar 2018 15:52:43 -0000 Subject: Re: [PATCH v2 08/38] cxlflash: Read host AFU configuration To: Uma Krishnan , linux-scsi@vger.kernel.org, James Bottomley , "Martin K. Petersen" , "Matthew R. Ochs" , "Manoj N. Kumar" Cc: linuxppc-dev@lists.ozlabs.org, Andrew Donnellan , Christophe Lombard References: <1519683513-16731-1-git-send-email-ukrishn@linux.vnet.ibm.com> <1519683660-17039-1-git-send-email-ukrishn@linux.vnet.ibm.com> From: Frederic Barrat Date: Thu, 22 Mar 2018 16:52:39 +0100 MIME-Version: 1.0 In-Reply-To: <1519683660-17039-1-git-send-email-ukrishn@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <11ba4bac-838a-06b2-0b5d-4da8903c13d1@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 26/02/2018 à 23:21, Uma Krishnan a écrit : > The host AFU configuration is read on the initialization path to identify > the features and configuration of the AFU. This data is cached for use in > later configuration steps. > > Signed-off-by: Uma Krishnan > Acked-by: Matthew R. Ochs > --- Reviewed-by: Frederic Barrat > drivers/scsi/cxlflash/ocxl_hw.c | 34 ++++++++++++++++++++++++++++++++++ > drivers/scsi/cxlflash/ocxl_hw.h | 1 + > 2 files changed, 35 insertions(+) > > diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c > index 39cccb7..2325030 100644 > --- a/drivers/scsi/cxlflash/ocxl_hw.c > +++ b/drivers/scsi/cxlflash/ocxl_hw.c > @@ -76,6 +76,33 @@ static int ocxlflash_config_fn(struct pci_dev *pdev, struct ocxl_hw_afu *afu) > } > > /** > + * ocxlflash_config_afu() - configure the host AFU > + * @pdev: PCI device associated with the host. > + * @afu: AFU associated with the host. > + * > + * Must be called _after_ host function configuration. > + * > + * Return: 0 on success, -errno on failure > + */ > +static int ocxlflash_config_afu(struct pci_dev *pdev, struct ocxl_hw_afu *afu) > +{ > + struct ocxl_afu_config *acfg = &afu->acfg; > + struct ocxl_fn_config *fcfg = &afu->fcfg; > + struct device *dev = &pdev->dev; > + int rc = 0; > + > + /* Read AFU config at index 0 */ > + rc = ocxl_config_read_afu(pdev, fcfg, acfg, 0); > + if (unlikely(rc)) { > + dev_err(dev, "%s: ocxl_config_read_afu failed rc=%d\n", > + __func__, rc); > + goto out; > + } > +out: > + return rc; > +} > + > +/** > * ocxlflash_create_afu() - create the AFU for OCXL > * @pdev: PCI device associated with the host. > * > @@ -102,6 +129,13 @@ static void *ocxlflash_create_afu(struct pci_dev *pdev) > __func__, rc); > goto err1; > } > + > + rc = ocxlflash_config_afu(pdev, afu); > + if (unlikely(rc)) { > + dev_err(dev, "%s: AFU configuration failed rc=%d\n", > + __func__, rc); > + goto err1; > + } > out: > return afu; > err1: > diff --git a/drivers/scsi/cxlflash/ocxl_hw.h b/drivers/scsi/cxlflash/ocxl_hw.h > index 190d71a..f6af247 100644 > --- a/drivers/scsi/cxlflash/ocxl_hw.h > +++ b/drivers/scsi/cxlflash/ocxl_hw.h > @@ -18,6 +18,7 @@ struct ocxl_hw_afu { > struct device *dev; /* Generic device */ > > struct ocxl_fn_config fcfg; /* DVSEC config of the function */ > + struct ocxl_afu_config acfg; /* AFU configuration data */ > > int fn_actag_base; /* Function acTag base */ > int fn_actag_enabled; /* Function acTag number enabled */ >