From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 6DC48DDE2E for ; Tue, 15 Jan 2008 15:22:32 +1100 (EST) Subject: Re: [PATCH] [POWERPC] Ensure we only handle PowerMac PCI bus fixup for memory resources From: Benjamin Herrenschmidt To: Kumar Gala In-Reply-To: References: Content-Type: text/plain Date: Tue, 15 Jan 2008 15:22:12 +1100 Message-Id: <1200370932.10470.6.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2008-01-14 at 20:44 -0600, Kumar Gala wrote: > The fixup code that handles the case for PowerMac's that leave bridge > windows open over an inaccessible region should only be applied to > memory resources (IORESOURCE_MEM). If not we can get it trying to fixup > IORESOURCE_IO on some systems since the other conditions that are used to > detect the case can easily match for IORESOURCE_IO. > > --- Ack. > in my git tree. > > arch/powerpc/kernel/pci-common.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c > index d394d41..7d0afd4 100644 > --- a/arch/powerpc/kernel/pci-common.c > +++ b/arch/powerpc/kernel/pci-common.c > @@ -806,7 +806,8 @@ static void __devinit __pcibios_fixup_bus(struct pci_bus *bus) > * equal to the pci_mem_offset of the host bridge and > * their size is smaller than 1M. > */ > - if (res->start == hose->pci_mem_offset && > + if (res->flags & IORESOURCE_MEM && > + res->start == hose->pci_mem_offset && > res->end < 0x100000) { > printk(KERN_INFO > "PCI: Closing bogus Apple Firmware"