Re: [PATCH] [POWERPC] Fixup transparent P2P resources

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Mon, 2008-01-14 at 20:45 -0600, Kumar Gala wrote:
> For transparent P2P bridges the first 3 resources may get set from based on
> BAR registers and need to get fixed up. Where as the remainder come from the
> parent bus and have already been fixed up.

Ack.

> ---
> 
> in my git tree.
> 
>  arch/powerpc/kernel/pci-common.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
> index 7d0afd4..980fe32 100644
> --- a/arch/powerpc/kernel/pci-common.c
> +++ b/arch/powerpc/kernel/pci-common.c
> @@ -792,9 +792,10 @@ static void __devinit __pcibios_fixup_bus(struct pci_bus *bus)
>  		for (i = 0; i < PCI_BUS_NUM_RESOURCES; ++i) {
>  			if ((res = bus->resource[i]) == NULL)
>  				continue;
> -			if (!res->flags || bus->self->transparent)
> +			if (!res->flags)
> +				continue;
> +			if (i >= 3 && bus->self->transparent)
>  				continue;
> -
>  			/* On PowerMac, Apple leaves bridge windows open over
>  			 * an inaccessible region of memory space (0...fffff)
>  			 * which is somewhat bogus, but that's what they think