* [PATCH] [POWERPC] Fixup transparent P2P resources
@ 2008-01-15 2:45 Kumar Gala
2008-01-15 4:22 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2008-01-15 2:45 UTC (permalink / raw)
To: linuxppc-dev
For transparent P2P bridges the first 3 resources may get set from based on
BAR registers and need to get fixed up. Where as the remainder come from the
parent bus and have already been fixed up.
---
in my git tree.
arch/powerpc/kernel/pci-common.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index 7d0afd4..980fe32 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -792,9 +792,10 @@ static void __devinit __pcibios_fixup_bus(struct pci_bus *bus)
for (i = 0; i < PCI_BUS_NUM_RESOURCES; ++i) {
if ((res = bus->resource[i]) == NULL)
continue;
- if (!res->flags || bus->self->transparent)
+ if (!res->flags)
+ continue;
+ if (i >= 3 && bus->self->transparent)
continue;
-
/* On PowerMac, Apple leaves bridge windows open over
* an inaccessible region of memory space (0...fffff)
* which is somewhat bogus, but that's what they think
--
1.5.3.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [POWERPC] Fixup transparent P2P resources
2008-01-15 2:45 [PATCH] [POWERPC] Fixup transparent P2P resources Kumar Gala
@ 2008-01-15 4:22 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2008-01-15 4:22 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Mon, 2008-01-14 at 20:45 -0600, Kumar Gala wrote:
> For transparent P2P bridges the first 3 resources may get set from based on
> BAR registers and need to get fixed up. Where as the remainder come from the
> parent bus and have already been fixed up.
Ack.
> ---
>
> in my git tree.
>
> arch/powerpc/kernel/pci-common.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
> index 7d0afd4..980fe32 100644
> --- a/arch/powerpc/kernel/pci-common.c
> +++ b/arch/powerpc/kernel/pci-common.c
> @@ -792,9 +792,10 @@ static void __devinit __pcibios_fixup_bus(struct pci_bus *bus)
> for (i = 0; i < PCI_BUS_NUM_RESOURCES; ++i) {
> if ((res = bus->resource[i]) == NULL)
> continue;
> - if (!res->flags || bus->self->transparent)
> + if (!res->flags)
> + continue;
> + if (i >= 3 && bus->self->transparent)
> continue;
> -
> /* On PowerMac, Apple leaves bridge windows open over
> * an inaccessible region of memory space (0...fffff)
> * which is somewhat bogus, but that's what they think
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-15 4:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-15 2:45 [PATCH] [POWERPC] Fixup transparent P2P resources Kumar Gala
2008-01-15 4:22 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).