From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 73204DDE3F for ; Tue, 15 Jan 2008 15:23:41 +1100 (EST) Subject: Re: [PATCH] [POWERPC] Fixup use of phys_addr_t in mpic code From: Benjamin Herrenschmidt To: Kumar Gala In-Reply-To: References: Content-Type: text/plain Date: Tue, 15 Jan 2008 15:23:19 +1100 Message-Id: <1200370999.10470.12.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2008-01-14 at 20:58 -0600, Kumar Gala wrote: > From: Becky Bruce > > The mpic_map() and __mpic_map_mmio() need to use phys_addr_t for the > physical address they are passed. > > Signed-off-by: Becky Bruce > Signed-off-by: Kumar Gala Ack. (or use resource_size_t, as you prefer). > --- > arch/powerpc/sysdev/mpic.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c > index f88ff09..0da7069 100644 > --- a/arch/powerpc/sysdev/mpic.c > +++ b/arch/powerpc/sysdev/mpic.c > @@ -267,7 +267,7 @@ static inline void _mpic_irq_write(struct mpic *mpic, unsigned int src_no, > */ > > > -static void _mpic_map_mmio(struct mpic *mpic, unsigned long phys_addr, > +static void _mpic_map_mmio(struct mpic *mpic, phys_addr_t phys_addr, > struct mpic_reg_bank *rb, unsigned int offset, > unsigned int size) > { > @@ -287,7 +287,7 @@ static void _mpic_map_dcr(struct mpic *mpic, struct mpic_reg_bank *rb, > BUG_ON(!DCR_MAP_OK(rb->dhost)); > } > > -static inline void mpic_map(struct mpic *mpic, unsigned long phys_addr, > +static inline void mpic_map(struct mpic *mpic, phys_addr_t phys_addr, > struct mpic_reg_bank *rb, unsigned int offset, > unsigned int size) > {