From: Michael Ellerman <michael@ellerman.id.au>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
THEMANN@de.ibm.com, linuxppc-dev@ozlabs.org, RAISCH@de.ibm.com,
Paul Mackerras <paulus@samba.org>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 1/2] Make setjmp/longjmp code generic
Date: Fri, 18 Jan 2008 08:49:22 +1100 [thread overview]
Message-ID: <1200606562.7295.4.camel@concordia> (raw)
In-Reply-To: <20080117064527.397cdfd6@zod.rchland.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]
On Thu, 2008-01-17 at 06:45 -0600, Josh Boyer wrote:
> On Thu, 17 Jan 2008 16:36:49 +1100
> Michael Neuling <mikey@neuling.org> wrote:
> > In message <20080117053857.GA29035@lixom.net> you wrote:
> > > Hi,
> > >
> > > On Thu, Jan 17, 2008 at 03:45:42PM +1100, Michael Neuling wrote:
> > >
> > > > Index: linux-2.6-ozlabs/include/asm-powerpc/setjmp.h
> > > > ===================================================================
> > > > --- /dev/null
> > > > +++ linux-2.6-ozlabs/include/asm-powerpc/setjmp.h
> > > > @@ -0,0 +1,18 @@
> > > > +/*
> > > > + * Copyright (C) 2007 Michael Neuling
> > ^^^^^^
> >
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License
> > > > + * as published by the Free Software Foundation; either version
> > > > + * 2 of the License, or (at your option) any later version.
> > > > + *
> > > > + */
> > > > +#ifndef _ASM_POWERPC_SETJMP_H
> > > > +#define _ASM_POWERPC_SETJMP_H
> > > > +
> > > > +#define JMP_BUF_LEN 23
> > > > +
> > > > +extern long setjmp(long *);
> > > > +extern void longjmp(long *, long);
> > > > +
> > > > +#endif /* _ASM_POWERPC_SETJMP_H */
> > >
> > > Should the above be inside #ifdef __KERNEL__?
> >
> > Yep... _and_ it's 2008 now!
> >
> > I'll update.
>
> While you're off updating it, remove the (C). It's bogus and shouldn't
> be there.
And it should say IBM corp too.
Oh and my car needs a wash when you're free ..
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-01-17 21:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 5:45 [PATCH 2/2] kdump shutdown hook support Michael Neuling
2007-12-12 7:01 ` Olof Johansson
2007-12-13 0:53 ` Michael Neuling
2007-12-12 23:07 ` Michael Ellerman
2007-12-13 0:04 ` Michael Neuling
2007-12-13 3:16 ` [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2007-12-13 3:16 ` [PATCH 2/2] kdump shutdown hook support Michael Neuling
2007-12-13 5:12 ` Olof Johansson
2007-12-13 5:13 ` Olof Johansson
2007-12-13 9:59 ` [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2007-12-13 9:59 ` [PATCH 2/2] kdump shutdown hook support Michael Neuling
2007-12-13 9:59 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2008-01-17 4:45 ` [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2008-01-17 4:45 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2008-01-17 5:38 ` Olof Johansson
2008-01-17 5:36 ` Michael Neuling
2008-01-17 6:36 ` Stephen Rothwell
2008-01-17 12:45 ` Josh Boyer
2008-01-17 21:49 ` Michael Ellerman [this message]
2008-01-17 22:16 ` [PATCH] Add crashdump shutdown hooks Michael Neuling
2008-01-17 22:16 ` [PATCH] Make setjmp/longjmp code generic Michael Neuling
2008-01-18 4:50 ` [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2008-01-18 4:50 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2008-01-18 4:50 ` [PATCH 2/2] kdump shutdown hook support Michael Neuling
2008-01-17 6:39 ` [PATCH 1/2] Make setjmp/longjmp code generic Stephen Rothwell
2008-01-17 4:45 ` [PATCH 2/2] kdump shutdown hook support Michael Neuling
2007-12-13 3:16 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
-- strict thread matches above, loose matches on Subject: below --
2007-12-12 5:45 Michael Neuling
2007-12-12 7:59 ` Kumar Gala
2007-12-12 8:06 ` Benjamin Herrenschmidt
2007-12-12 9:37 ` Stephen Rothwell
2007-12-12 9:44 ` Benjamin Herrenschmidt
2007-12-12 11:09 ` Michael Neuling
2007-12-12 22:56 ` Michael Ellerman
2007-12-12 23:40 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200606562.7295.4.camel@concordia \
--to=michael@ellerman.id.au \
--cc=RAISCH@de.ibm.com \
--cc=THEMANN@de.ibm.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).