From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
i2c@lm-sensors.org
Subject: Re: [i2c] [PATCH 19 3/5] Clean up error returns
Date: Tue, 22 Jan 2008 10:04:44 +1100 [thread overview]
Message-ID: <1200956684.6807.14.camel@pasglop> (raw)
In-Reply-To: <20080121171025.524dc465@hyperion.delvare>
On Mon, 2008-01-21 at 17:10 +0100, Jean Delvare wrote:
> Hi Jon,
>
> On Sun, 20 Jan 2008 10:39:43 -0500, Jon Smirl wrote:
> > Here' s a version with the compares to zero switched to NO_IRQ. If I
> > understand how NO_IRQ works it is the correct change. My understanding
> > is that under ppc IRQ zero was legal and NO_IRQ was -1. But then the
> > whole kernel switched to NO_IRQ = zero. Powerpc updated to NO_IRQ=0
> > and used virtual IRQs to move a physical IRQ 0 to another IRQ number.
> > ppc was not changed. This driver does not appear to have been updated
> > to track this global change since it didn't initially use the NO_IRQ
> > define everywhere.
>
> As I have already applied the part of this patch that preserves error
> values in error paths, can you please send an incremental patch that
> only fixes the IRQ issues? These are separate issues so it's better to
> have separate patches anyway.
To be clear, nowadays, checking against 0 is correct unless you intend
the driver to work with arch/ppc (which we'll deprecate soon).
Ben.
next prev parent reply other threads:[~2008-01-21 23:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 2:47 [PATCH 19 0/5] Version 18, series to add device tree naming to i2c Jon Smirl
2008-01-12 2:47 ` [PATCH 19 1/5] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2008-01-12 3:00 ` [i2c] " Jon Smirl
2008-01-12 3:47 ` Stephen Rothwell
2008-01-12 2:47 ` [PATCH 19 2/5] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2008-01-12 2:47 ` [PATCH 19 3/5] Clean up error returns Jon Smirl
2008-01-20 11:07 ` [i2c] " Jean Delvare
2008-01-20 15:18 ` Jon Smirl
2008-01-20 15:39 ` Jon Smirl
2008-01-21 16:10 ` Jean Delvare
2008-01-21 23:04 ` Benjamin Herrenschmidt [this message]
2008-01-21 23:06 ` Benjamin Herrenschmidt
2008-01-12 2:47 ` [PATCH 19 4/5] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2008-01-12 4:07 ` Stephen Rothwell
2008-01-12 2:47 ` [PATCH 19 5/5] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2008-04-10 9:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200956684.6807.14.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).