From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ppc: fix #ifdef-s in mediabay driver
Date: Wed, 23 Jan 2008 10:59:54 +1100 [thread overview]
Message-ID: <1201046394.6807.49.camel@pasglop> (raw)
In-Reply-To: <200801230012.38516.bzolnier@gmail.com>
On Wed, 2008-01-23 at 00:12 +0100, Bartlomiej Zolnierkiewicz wrote:
> * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
> check_media_bay() by CONFIG_MAC_FLOPPY one.
>
> * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef-s by
> CONFIG_BLK_DEV_IDE_PMAC ones.
>
> * check_media_bay() is used only by drivers/block/swim3.c
> so make this function available only if CONFIG_MAC_FLOPPY
> is defined.
>
> * check_media_bay_by_base() and media_bay_set_ide_infos()
> are used only by drivers/ide/ppc/pmac.c so so make these
> functions available only if CONFIG_MAC_FLOPPY is defined.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> Ben, IMO this patch is safe for 2.6.24 (assuming that it builds fine :),
> otherwise I would like to ask for permission to merge it through IDE
> tree since I have other pending IDE patches depending on this one.
I'd rather avoid touching 2.6.24 unless it actually fixes a bug or
regression...
I'm tempted to actually remove all ifdef's ... if you have a media-bay,
then there are about 99% chances it contains an IDE device, with the
remaining percent being split with putting a floppy or a battery in. I
doubt anybody will care building a kernel without the support for these
and with the mediabay support, and still want to save a handful of bytes
in that driver.
Ben.
next prev parent reply other threads:[~2008-01-23 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 23:12 [PATCH] ppc: fix #ifdef-s in mediabay driver Bartlomiej Zolnierkiewicz
2008-01-22 23:59 ` Benjamin Herrenschmidt [this message]
2008-01-23 0:58 ` Bartlomiej Zolnierkiewicz
2008-01-23 4:17 ` Benjamin Herrenschmidt
2008-01-23 12:47 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201046394.6807.49.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).