From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>
Subject: Re: [PATCH 1/3 v3] Add StorCenter DTS first draft.
Date: Wed, 23 Jan 2008 11:33:16 +1100 [thread overview]
Message-ID: <1201048396.6807.52.camel@pasglop> (raw)
In-Reply-To: <fa686aa40801221449p28889ea5r68bd726726558dc0@mail.gmail.com>
> > +
> > + mpic: interrupt-controller@40000 {
> > + #interrupt-cells = <2>;
> > + #address-cells = <0>;
>
> Is #address-cells needed? There are no child nodes.
It's preferrable for interrupt controllers as #address-cells of the
parent interrupt controller defines the size of the interrupt unit
specifier in the child in the interrupt tree.
I think there's an ongoing argument as to whether the absence of
#address-cells should be the same as #address-cells = 0 in that specific
case but I'm not sure the code does the right thing so let's have it
explicit.
Ben.
next prev parent reply other threads:[~2008-01-23 0:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 22:37 [PATCH 1/3 v3] Add StorCenter DTS first draft Jon Loeliger
2008-01-22 22:49 ` Grant Likely
2008-01-22 22:54 ` Jon Loeliger
2008-01-22 23:16 ` Grant Likely
2008-01-23 0:33 ` Benjamin Herrenschmidt [this message]
2008-01-23 0:47 ` Scott Wood
2008-01-23 1:39 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201048396.6807.52.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).