[PATCH] hide kernel only code in asm-powerpc/elf.h

[PATCH] hide kernel only code in asm-powerpc/elf.h

[Olaf Hering]

stuff inside CONFIG_* should not be exported via make headers-install

Signed-off-by: Olaf Hering <olaf@aepfle.de>

---
 include/asm-powerpc/elf.h |    2 ++
 1 file changed, 2 insertions(+)

--- a/include/asm-powerpc/elf.h
+++ b/include/asm-powerpc/elf.h
@@ -420,6 +420,7 @@ do {									\
 /* Keep this the last entry.  */
 #define R_PPC64_NUM		107
 
+#ifdef __KERNEL__
 #ifdef CONFIG_SPU_BASE
 /* Notes used in ET_CORE. Note name is "SPU/<fd>/<filename>". */
 #define NT_SPU		1
@@ -427,5 +428,6 @@ do {									\
 #define ARCH_HAVE_EXTRA_ELF_NOTES
 
 #endif /* CONFIG_SPU_BASE */
+#endif /* __KERNEL__ */
 
 #endif /* _ASM_POWERPC_ELF_H */

Re: [PATCH] hide kernel only code in asm-powerpc/elf.h

[Arnd Bergmann]

On Friday 25 January 2008, Olaf Hering wrote:
> stuff inside CONFIG_* should not be exported via make headers-install
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

I think at some point I even had a script to automatically check
for this kind of bug. Using any #ifdef CONFIG_* in an exported
header is guaranteed to be a bug, because we don't export
config.h.

	Arnd <><

Re: [PATCH] hide kernel only code in asm-powerpc/elf.h

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

On Fri, 2008-01-25 at 19:08 +0100, Olaf Hering wrote:
> stuff inside CONFIG_* should not be exported via make headers-install
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> ---
>  include/asm-powerpc/elf.h |    2 ++
>  1 file changed, 2 insertions(+)

Thanks Olaf, I noticed that once but forgot to fix it.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]