* [PATCH] hide kernel only code in asm-powerpc/elf.h
@ 2008-01-25 18:08 Olaf Hering
2008-01-28 20:14 ` Arnd Bergmann
2008-01-30 1:42 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Olaf Hering @ 2008-01-25 18:08 UTC (permalink / raw)
To: Paul Mackeras, linuxppc-dev
stuff inside CONFIG_* should not be exported via make headers-install
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
include/asm-powerpc/elf.h | 2 ++
1 file changed, 2 insertions(+)
--- a/include/asm-powerpc/elf.h
+++ b/include/asm-powerpc/elf.h
@@ -420,6 +420,7 @@ do { \
/* Keep this the last entry. */
#define R_PPC64_NUM 107
+#ifdef __KERNEL__
#ifdef CONFIG_SPU_BASE
/* Notes used in ET_CORE. Note name is "SPU/<fd>/<filename>". */
#define NT_SPU 1
@@ -427,5 +428,6 @@ do { \
#define ARCH_HAVE_EXTRA_ELF_NOTES
#endif /* CONFIG_SPU_BASE */
+#endif /* __KERNEL__ */
#endif /* _ASM_POWERPC_ELF_H */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hide kernel only code in asm-powerpc/elf.h
2008-01-25 18:08 [PATCH] hide kernel only code in asm-powerpc/elf.h Olaf Hering
@ 2008-01-28 20:14 ` Arnd Bergmann
2008-01-30 1:42 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2008-01-28 20:14 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Olaf Hering, Paul Mackeras
On Friday 25 January 2008, Olaf Hering wrote:
> stuff inside CONFIG_* should not be exported via make headers-install
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I think at some point I even had a script to automatically check
for this kind of bug. Using any #ifdef CONFIG_* in an exported
header is guaranteed to be a bug, because we don't export
config.h.
Arnd <><
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hide kernel only code in asm-powerpc/elf.h
2008-01-25 18:08 [PATCH] hide kernel only code in asm-powerpc/elf.h Olaf Hering
2008-01-28 20:14 ` Arnd Bergmann
@ 2008-01-30 1:42 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2008-01-30 1:42 UTC (permalink / raw)
To: Olaf Hering; +Cc: linuxppc-dev, Paul Mackeras
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Fri, 2008-01-25 at 19:08 +0100, Olaf Hering wrote:
> stuff inside CONFIG_* should not be exported via make headers-install
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> ---
> include/asm-powerpc/elf.h | 2 ++
> 1 file changed, 2 insertions(+)
Thanks Olaf, I noticed that once but forgot to fix it.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-30 1:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-25 18:08 [PATCH] hide kernel only code in asm-powerpc/elf.h Olaf Hering
2008-01-28 20:14 ` Arnd Bergmann
2008-01-30 1:42 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).