From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table
Date: Thu, 31 Jan 2008 10:14:58 +1100 [thread overview]
Message-ID: <1201734898.8146.0.camel@pasglop> (raw)
In-Reply-To: <200801300716.52463.sr@denx.de>
On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote:
> On Wednesday 16 January 2008, Josh Boyer wrote:
> > On Wed, 16 Jan 2008 20:53:59 +1100
> >
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > > On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote:
> > > > With the removal the the "rgmii-interface" device_type property from
> > > > the dts files, the newemac driver needs an update to only rely on
> > > > compatible property.
> > > >
> > > > Signed-off-by: Stefan Roese <sr@denx.de>
> > >
> > > I need to test if it works on CAB, can't change the DT on those. I'll
> > > let you know tomorrow.
> >
> > This should be fine on CAB. The rgmii node has:
> >
> > compatible = "ibm,rgmii-axon", "ibm,rgmii"
> >
> > so the match should still catch on the latter.
>
> How about this patch? Ben, if you think this is ok then we should make sure
> that it goes in in this merge-window, since the other dts patch relies on it.
It's fine.
Ben.
next prev parent reply other threads:[~2008-01-30 23:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 9:37 [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table Stefan Roese
2008-01-16 9:39 ` David Gibson
2008-01-16 9:53 ` Benjamin Herrenschmidt
2008-01-16 15:01 ` Josh Boyer
2008-01-30 6:16 ` Stefan Roese
2008-01-30 23:14 ` Benjamin Herrenschmidt [this message]
2008-02-05 21:12 ` Josh Boyer
2008-02-05 21:18 ` Benjamin Herrenschmidt
2008-02-06 12:12 ` Jeff Garzik
2008-02-06 12:16 ` Stefan Roese
2008-01-17 20:53 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2008-02-06 12:21 Stefan Roese
2008-02-06 12:49 ` Josh Boyer
2008-02-11 16:08 ` Jeff Garzik
2008-02-06 16:01 ` Olof Johansson
2008-02-06 16:23 ` Josh Boyer
2008-02-06 16:35 ` Olof Johansson
2008-02-07 2:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201734898.8146.0.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).