From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bastian Blank <bastian@waldi.eu.org>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix ext4 bitops
Date: Sun, 03 Feb 2008 18:36:38 +1100 [thread overview]
Message-ID: <1202024198.7208.9.camel@pasglop> (raw)
In-Reply-To: <20080201200240.GA28566@wavehammer.waldi.eu.org>
On Fri, 2008-02-01 at 21:02 +0100, Bastian Blank wrote:
> Fix ext4 bitops.
Please provide a better description, as it's not obvious at first sight.
> Signed-off-by: Bastian Blank <waldi@debian.org>
>
> diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h
> index 220d9a7..d0980df 100644
> --- a/include/asm-powerpc/bitops.h
> +++ b/include/asm-powerpc/bitops.h
> @@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit(const unsigned long *addr,
> unsigned long size, unsigned long offset);
> /* Bitmap functions for the ext2 filesystem */
>
> +#include <asm-generic/bitops/le.h>
A comment would be useful to indicate that this defines the _le versions
of the bitops as it would be easy to mistake that for something else.
> #define ext2_set_bit(nr,addr) \
> __test_and_set_le_bit((nr), (unsigned long*)addr)
> #define ext2_clear_bit(nr, addr) \
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2008-02-03 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 20:02 [PATCH] Fix ext4 bitops Bastian Blank
2008-02-03 7:36 ` Benjamin Herrenschmidt [this message]
2008-02-04 5:22 ` Aneesh Kumar K.V
[not found] <20080201200208.GA28274@wavehammer.waldi.eu.org>
[not found] ` <20080201122257.9524c2bb.akpm@linux-foundation.org>
[not found] ` <20080201210404.GA31271@wavehammer.waldi.eu.org>
[not found] ` <20080203121238.GD18211@osiris.ibm.com>
2008-02-03 12:39 ` Geert Uytterhoeven
2008-02-04 4:50 ` Aneesh Kumar K.V
2008-02-04 9:24 ` Heiko Carstens
2008-02-04 9:29 ` Aneesh Kumar K.V
2008-02-04 20:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202024198.7208.9.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=bastian@waldi.eu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).