From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: asm-offsets.c
Date: Thu, 07 Feb 2008 19:44:48 +1100 [thread overview]
Message-ID: <1202373888.7079.124.camel@pasglop> (raw)
In-Reply-To: <47AA8C7D.3030109@pikatech.com>
On Wed, 2008-02-06 at 23:43 -0500, Sean MacLennan wrote:
> I just did a git pull of Josh's tree, and
> arch/powerpc/kernel/asm-offsets.c does not compile. I have only been
> glossing over the linuxppc-dev emails, so forgive me if this already
> came up.
>
> It looks like, at least for the Warp, CLOCK_REALTIME_RES is not defined
> so asm-offsets.c gets an error. The following patch fixes it.... but I
> am not sure it is right since I don't know if CLOCK_REALTIME_RES should
> be defined.
Hrm... this macro should -define- CLOCK_REALTIME_RES, not rely on an
existing definition...
> Cheers,
> Sean
>
> diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets
> .c
> index e6e4928..c1568aa 100644
> --- a/arch/powerpc/kernel/asm-offsets.c
> +++ b/arch/powerpc/kernel/asm-offsets.c
> @@ -313,7 +313,9 @@ int main(void)
> DEFINE(CLOCK_REALTIME, CLOCK_REALTIME);
> DEFINE(CLOCK_MONOTONIC, CLOCK_MONOTONIC);
> DEFINE(NSEC_PER_SEC, NSEC_PER_SEC);
> +#ifdef CLOCK_REALTIME_RES
> DEFINE(CLOCK_REALTIME_RES, (KTIME_MONOTONIC_RES).tv64);
> +#endif
>
> #ifdef CONFIG_BUG
> DEFINE(BUG_ENTRY_SIZE, sizeof(struct bug_entry));
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2008-02-07 8:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 4:43 asm-offsets.c Sean MacLennan
2008-02-07 4:51 ` asm-offsets.c Christoph Hellwig
2008-02-07 6:49 ` asm-offsets.c Nathan Lynch
2008-02-07 6:55 ` asm-offsets.c Christoph Hellwig
2008-02-07 7:02 ` asm-offsets.c Sean MacLennan
2008-02-07 7:16 ` asm-offsets.c Nathan Lynch
2008-02-07 7:26 ` asm-offsets.c Sean MacLennan
2008-02-07 5:07 ` asm-offsets.c Tony Breeds
2008-02-07 5:13 ` asm-offsets.c Sean MacLennan
2008-02-07 8:44 ` Benjamin Herrenschmidt [this message]
2008-02-07 20:24 ` asm-offsets.c Sean MacLennan
2008-02-07 19:01 ` asm-offsets.c Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202373888.7079.124.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).