From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
kyle@mcmartin.ca, LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] FIx compile of swim3 as module
Date: Wed, 13 Feb 2008 17:03:52 +1100 [thread overview]
Message-ID: <1202882632.7296.25.camel@pasglop> (raw)
In-Reply-To: <20080212204802.18a7a868@zod.rchland.ibm.com>
On Tue, 2008-02-12 at 20:48 -0600, Josh Boyer wrote:
> > The current pmac32_defconfig fails to build with the following
> error:
> >
> > Building modules, stage 2.
> > ERROR: "check_media_bay" [drivers/block/swim3.ko] undefined!
> > WARNING: modpost: Found 23 section mismatch(es).
> > To see full details build your kernel with:
> > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > make[2]: *** [__modpost] Error 1
> >
> > This patch fixes that.
>
> Kyle posted a slightly different patch that seemed to still keep
> the original intention of ifdefery in tact. I've no idea which is
> better, but the three of you might want to compare notes.
Just remove the bloody ifdef's, they are just a useless pain.
Ben.
next prev parent reply other threads:[~2008-02-13 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 2:40 [PATCH] FIx compile of swim3 as module Tony Breeds
2008-02-13 2:48 ` Josh Boyer
2008-02-13 2:51 ` Tony Breeds
2008-02-13 6:03 ` Benjamin Herrenschmidt [this message]
2008-02-13 3:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202882632.7296.25.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=kyle@mcmartin.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).