From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/8] Remove unused pte_offset variable
Date: Wed, 27 Feb 2008 19:18:49 +1100 [thread overview]
Message-ID: <1204100329.15052.229.camel@pasglop> (raw)
In-Reply-To: <1204099860.6932.2.camel@concordia>
On Wed, 2008-02-27 at 19:11 +1100, Michael Ellerman wrote:
> I'm pretty sure I tested it and it worked.
>
> But I didn't actually change anything WRT the spider offset anyway, we
> still add it to it_offset just like we used to, it's just we don't put
> it in the window and then pull it out again.
>
> The only thing that's changed is we now use offset (aka. base) in the
> tce routines in addition to pte_offset.
Ok. Should be fine then.
Ben.
next prev parent reply other threads:[~2008-02-27 8:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 7:28 [PATCH 1/8] Clearup cell IOMMU fixed mapping terminology Michael Ellerman
2008-02-27 7:28 ` [PATCH 2/8] Use it_offset not pte_offset in cell IOMMU code Michael Ellerman
2008-02-27 7:28 ` [PATCH 3/8] Remove unused pte_offset variable Michael Ellerman
2008-02-27 8:04 ` Benjamin Herrenschmidt
2008-02-27 8:11 ` Michael Ellerman
2008-02-27 8:18 ` Benjamin Herrenschmidt [this message]
2008-02-27 7:28 ` [PATCH 4/8] Move allocation of cell IOMMU pad page Michael Ellerman
2008-02-27 7:28 ` [PATCH 5/8] Split setup of IOMMU stab and ptab, allocate dynamic/fixed ptabs separately Michael Ellerman
2008-02-27 7:28 ` [PATCH 6/8] Cell IOMMU: n_pte_pages is in 4K page units, not IOMMU_PAGE_SIZE Michael Ellerman
2008-02-27 7:28 ` [PATCH 7/8] Allow for different IOMMU page sizes in cell IOMMU code Michael Ellerman
2008-02-27 7:28 ` [PATCH 8/8] Convert the cell IOMMU fixed mapping to 16M IOMMU pages Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2008-02-29 7:33 [PATCH 1/8] Clearup cell IOMMU fixed mapping terminology Michael Ellerman
2008-02-29 7:33 ` [PATCH 3/8] Remove unused pte_offset variable Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204100329.15052.229.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).