From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 1C879DDD0C for ; Thu, 28 Feb 2008 13:41:05 +1100 (EST) Subject: Re: [PATCH 1/2] firewire: endianess fix From: Benjamin Herrenschmidt To: Jarod Wilson In-Reply-To: <200802271458.28401.jwilson@redhat.com> References: <20080220220326.GA22328@uranus.ravnborg.org> <200802271458.28401.jwilson@redhat.com> Content-Type: text/plain Date: Thu, 28 Feb 2008 13:40:22 +1100 Message-Id: <1204166422.15052.334.camel@pasglop> Mime-Version: 1.0 Cc: Kristian Hoegsberg , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Stefan Richter , sparclinux@vger.kernel.org, linux1394-devel@lists.sourceforge.net, Sam Ravnborg , Harvey Harrison Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2008-02-27 at 14:58 -0500, Jarod Wilson wrote: > On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > > The generation of incoming requests was filled in in wrong byte order on > > machines with big endian CPU. > > > > Signed-off-by: Stefan Richter > > Cc: sparclinux@vger.kernel.org > > Cc: linuxppc-dev@ozlabs.org > > --- > > > > This patch is a shot in the dark, based on a warning when building with > > C=1 CHECKFLAGS="-D__CHECK_ENDIAN__". Is it really a fix, or was the > > previous code accidentally correct? > > > > This needs to be tested on different big endian PCs, if possible with > > the Apple Uninorth FireWire controller and other types of controllers. > > One test which involves ohci->request_generation is simply with an SBP-2 > > device (harddisk, CD-ROM...). Does SBP-2 login etc. work? > > Works just fine with the Apple UniNorth controller in my powerbook in cursory > testing. Tested with multiple sbp2 hard disks, plugging and unplugging, > mounting and unmounting, etc. Which specific rev/version of the uninorth controller ? There is the "interesting" one has vendorID Apple and deviceID 0x0018, the normal ones have different deviceIDs (and are just lucent controllers afaik). Ben.