From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 94A20DDE34 for ; Tue, 4 Mar 2008 07:37:05 +1100 (EST) Subject: Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources() From: Benjamin Herrenschmidt To: Jesse Barnes In-Reply-To: <200803030959.35625.jbarnes@virtuousgeek.org> References: <20080228000437.880811124@ldl.fc.hp.com> <20080228001053.013269726@ldl.fc.hp.com> <200803030959.35625.jbarnes@virtuousgeek.org> Content-Type: text/plain Date: Tue, 04 Mar 2008 07:35:57 +1100 Message-Id: <1204576557.21545.4.camel@pasglop> Mime-Version: 1.0 Cc: linux-arch@vger.kernel.org, Chris Zankel , Grant Grundler , linux-parisc@vger.kernel.org, Matthew Wilcox , Kyle McMartin , linuxppc-dev@ozlabs.org, Paul Mackerras , linux-pci@atrey.karlin.mff.cuni.cz, linux-arm-kernel@lists.arm.linux.org.uk, Russell King , Bjorn Helgaas Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2008-03-03 at 09:59 -0800, Jesse Barnes wrote: > On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote: > > Move bridge enable from pcibios_enable_resources() to > > platform_pci_enable_device() so the former matches other > > architectures and can be shared. > > I really like the direction of these patches. Getting PCI resources assigned > & devices setup correctly for new arches has always been a bit more trouble > than it should be... You'll noticed that I recently moved powerpc to something more common to x86 in the are of resource allocation. Still -slightly- different but I do believe there is room for somebody with some skills to try to turn some of that into generic code. Ben.