From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ares.ids.de (ares.ids.de [213.144.29.131]) by ozlabs.org (Postfix) with ESMTP id 9661FDDDF3 for ; Tue, 11 Mar 2008 00:17:31 +1100 (EST) Received: from ares.ids.de (ares.ids.de [127.0.0.1]) by ares.ids.de (PGP Universal) with ESMTP id 8D96EF4910E for ; Mon, 10 Mar 2008 14:17:29 +0100 (CET) Subject: Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set. From: Sergej Stepanov To: Laurent Pinchart In-Reply-To: <200803101205.16158.laurentp@cse-semaphore.com> References: <20070920220121.GF28784@loki.buserror.net> <20080307163747.GF10545@ld0162-tx32.am.freescale.net> <1205135421.3837.1.camel@p60365-ste> <200803101205.16158.laurentp@cse-semaphore.com> Date: Mon, 10 Mar 2008 14:17:28 +0100 Message-Id: <1205155048.4627.5.camel@p60365-ste> Mime-Version: 1.0 Content-Type: text/plain Cc: Scott Wood , linuxppc-dev@ozlabs.org, jgarzik@pobox.com, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am Montag, den 10.03.2008, 12:05 +0100 schrieb Laurent Pinchart: > Your documentation patch states that > > "The first reg resource is the I/O port register block on which MDIO > resides. The second reg resource is the I/O port register block on > which MDC resides. If there is only one reg resource, it is used for > both MDIO and MDC." > > If I'm not mistaken the code uses the first reg resource for MDC and the > second reg resource for MDIO. Which one should be fixed, the doc or the > code ? > > Best regards, > Ooops... Sorry... You are right: the first is MDC, second MDIO. I have to fix the docu, it would be simpler. Thank you and best regards Sergej.