From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH 1/2 v2] [POWERPC] Add PPC4xx L2-cache support (440GX)
Date: Tue, 25 Mar 2008 07:59:15 +1100 [thread overview]
Message-ID: <1206392355.7197.38.camel@pasglop> (raw)
In-Reply-To: <20080324083957.2945077c@zod.rchland.ibm.com>
On Mon, 2008-03-24 at 08:39 -0500, Josh Boyer wrote:
> > +
> > + local_irq_save(flags);
> > + asm volatile ("sync" ::: "memory");
>
> Perhaps just call iosync() for these instead of the open coded asm
> volatile stuff?
Not sure about that. iosync() will do a sync but it's not meant at being
used for things unrelated to IOs (and who knows... we might make it do
something else one day ?).
In low level arch code like that, an open coded sync might be proper
especially if it matches some documented sequence.
Cheers,
Ben.
next prev parent reply other threads:[~2008-03-24 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 10:28 [PATCH 1/2 v2] [POWERPC] Add PPC4xx L2-cache support (440GX) Stefan Roese
2008-03-24 13:39 ` Josh Boyer
2008-03-24 20:59 ` Benjamin Herrenschmidt [this message]
2008-03-24 21:15 ` Josh Boyer
2008-03-25 6:21 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206392355.7197.38.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).