From: Michael Ellerman <michael@ellerman.id.au>
To: Nathan Lynch <ntl@pobox.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] scanlog_init cleanup, minor fixes
Date: Thu, 27 Mar 2008 10:21:28 +1100 [thread overview]
Message-ID: <1206573688.7482.2.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <20080326230959.GI7137@localdomain>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
On Wed, 2008-03-26 at 18:09 -0500, Nathan Lynch wrote:
> Michael Ellerman wrote:
> > > + /* Ideally we could allocate a buffer < 4G */
> > > + data = kzalloc(RTAS_DATA_BUF_SIZE, GFP_KERNEL);
> > > + if (!data)
> > > + goto err;
> >
> > Not your bug, but what happens if data is > 4G? Kaboom?
>
> An old RPA doc (scan-log-dump isn't specified in PAPR) says the buffer
> should be "contiguous real storage", so... yeah, probably. That's why
> I preserved the comment. Will fix if I get access to a machine to
> test this code more thoroughly (plenty of other issues in this file,
> too).
Cool, no point changing it if we can't test it.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-03-26 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 22:51 [PATCH] scanlog_init cleanup, minor fixes Nathan Lynch
2008-03-26 22:40 ` Michael Ellerman
2008-03-26 23:09 ` Nathan Lynch
2008-03-26 23:21 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206573688.7482.2.camel@concordia.ozlabs.ibm.com \
--to=michael@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).