* [PATCH][NEWEMAC] Fix section mismatch warnings
@ 2008-03-02 22:37 Josh Boyer
2008-03-30 1:36 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2008-03-02 22:37 UTC (permalink / raw)
To: benh; +Cc: linuxppc-dev, netdev
This patch fixes several section mismatch warnings in the
ibm_newemac driver similar to:
WARNING: vmlinux.o(.devinit.text+0x3a04): Section mismatch in reference from the function emac_probe() to the function .devexit.text:tah_detach()
The function __devinit emac_probe() references
a function __devexit tah_detach().
Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
---
drivers/net/ibm_newemac/core.c | 2 +-
drivers/net/ibm_newemac/mal.c | 4 ++--
drivers/net/ibm_newemac/rgmii.c | 2 +-
drivers/net/ibm_newemac/tah.c | 2 +-
drivers/net/ibm_newemac/zmii.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
--- linux-2.6.orig/drivers/net/ibm_newemac/core.c
+++ linux-2.6/drivers/net/ibm_newemac/core.c
@@ -2230,7 +2230,7 @@ static int __devinit emac_of_bus_notify(
return 0;
}
-static struct notifier_block emac_of_bus_notifier = {
+static struct notifier_block emac_of_bus_notifier __devinitdata = {
.notifier_call = emac_of_bus_notify
};
--- linux-2.6.orig/drivers/net/ibm_newemac/mal.c
+++ linux-2.6/drivers/net/ibm_newemac/mal.c
@@ -61,8 +61,8 @@ int __devinit mal_register_commac(struct
return 0;
}
-void __devexit mal_unregister_commac(struct mal_instance *mal,
- struct mal_commac *commac)
+void mal_unregister_commac(struct mal_instance *mal,
+ struct mal_commac *commac)
{
unsigned long flags;
--- linux-2.6.orig/drivers/net/ibm_newemac/rgmii.c
+++ linux-2.6/drivers/net/ibm_newemac/rgmii.c
@@ -179,7 +179,7 @@ void rgmii_put_mdio(struct of_device *of
mutex_unlock(&dev->lock);
}
-void __devexit rgmii_detach(struct of_device *ofdev, int input)
+void rgmii_detach(struct of_device *ofdev, int input)
{
struct rgmii_instance *dev = dev_get_drvdata(&ofdev->dev);
struct rgmii_regs __iomem *p = dev->base;
--- linux-2.6.orig/drivers/net/ibm_newemac/tah.c
+++ linux-2.6/drivers/net/ibm_newemac/tah.c
@@ -35,7 +35,7 @@ int __devinit tah_attach(struct of_devic
return 0;
}
-void __devexit tah_detach(struct of_device *ofdev, int channel)
+void tah_detach(struct of_device *ofdev, int channel)
{
struct tah_instance *dev = dev_get_drvdata(&ofdev->dev);
--- linux-2.6.orig/drivers/net/ibm_newemac/zmii.c
+++ linux-2.6/drivers/net/ibm_newemac/zmii.c
@@ -189,7 +189,7 @@ void zmii_set_speed(struct of_device *of
mutex_unlock(&dev->lock);
}
-void __devexit zmii_detach(struct of_device *ofdev, int input)
+void zmii_detach(struct of_device *ofdev, int input)
{
struct zmii_instance *dev = dev_get_drvdata(&ofdev->dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][NEWEMAC] Fix section mismatch warnings
2008-03-02 22:37 [PATCH][NEWEMAC] Fix section mismatch warnings Josh Boyer
@ 2008-03-30 1:36 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2008-03-30 1:36 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, netdev
On Sun, 2008-03-02 at 16:37 -0600, Josh Boyer wrote:
> This patch fixes several section mismatch warnings in the
> ibm_newemac driver similar to:
>
> WARNING: vmlinux.o(.devinit.text+0x3a04): Section mismatch in reference from the function emac_probe() to the function .devexit.text:tah_detach()
> The function __devinit emac_probe() references
> a function __devexit tah_detach().
>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Ack.
> ---
> drivers/net/ibm_newemac/core.c | 2 +-
> drivers/net/ibm_newemac/mal.c | 4 ++--
> drivers/net/ibm_newemac/rgmii.c | 2 +-
> drivers/net/ibm_newemac/tah.c | 2 +-
> drivers/net/ibm_newemac/zmii.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/core.c
> +++ linux-2.6/drivers/net/ibm_newemac/core.c
> @@ -2230,7 +2230,7 @@ static int __devinit emac_of_bus_notify(
> return 0;
> }
>
> -static struct notifier_block emac_of_bus_notifier = {
> +static struct notifier_block emac_of_bus_notifier __devinitdata = {
> .notifier_call = emac_of_bus_notify
> };
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/mal.c
> +++ linux-2.6/drivers/net/ibm_newemac/mal.c
> @@ -61,8 +61,8 @@ int __devinit mal_register_commac(struct
> return 0;
> }
>
> -void __devexit mal_unregister_commac(struct mal_instance *mal,
> - struct mal_commac *commac)
> +void mal_unregister_commac(struct mal_instance *mal,
> + struct mal_commac *commac)
> {
> unsigned long flags;
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/rgmii.c
> +++ linux-2.6/drivers/net/ibm_newemac/rgmii.c
> @@ -179,7 +179,7 @@ void rgmii_put_mdio(struct of_device *of
> mutex_unlock(&dev->lock);
> }
>
> -void __devexit rgmii_detach(struct of_device *ofdev, int input)
> +void rgmii_detach(struct of_device *ofdev, int input)
> {
> struct rgmii_instance *dev = dev_get_drvdata(&ofdev->dev);
> struct rgmii_regs __iomem *p = dev->base;
> --- linux-2.6.orig/drivers/net/ibm_newemac/tah.c
> +++ linux-2.6/drivers/net/ibm_newemac/tah.c
> @@ -35,7 +35,7 @@ int __devinit tah_attach(struct of_devic
> return 0;
> }
>
> -void __devexit tah_detach(struct of_device *ofdev, int channel)
> +void tah_detach(struct of_device *ofdev, int channel)
> {
> struct tah_instance *dev = dev_get_drvdata(&ofdev->dev);
>
> --- linux-2.6.orig/drivers/net/ibm_newemac/zmii.c
> +++ linux-2.6/drivers/net/ibm_newemac/zmii.c
> @@ -189,7 +189,7 @@ void zmii_set_speed(struct of_device *of
> mutex_unlock(&dev->lock);
> }
>
> -void __devexit zmii_detach(struct of_device *ofdev, int input)
> +void zmii_detach(struct of_device *ofdev, int input)
> {
> struct zmii_instance *dev = dev_get_drvdata(&ofdev->dev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-30 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-02 22:37 [PATCH][NEWEMAC] Fix section mismatch warnings Josh Boyer
2008-03-30 1:36 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).