From: "Joakim Tjernlund" <joakim.tjernlund@transmode.se>
To: "Mike Hench" <mhench@engagenet.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] mpc83xx SPI glitch
Date: Mon, 31 Mar 2008 15:23:49 +0200 [thread overview]
Message-ID: <1206969829.7589.463.camel@gentoo-jocke.transmode.se> (raw)
In-Reply-To: <6629C06B144F5C4098DFF95C4FF9DAF702BA1FA0@mailsrv.engagenet.com>
Mike
I already sent a patch some time ago, it addresses this bug and
alot more. See spi-devel-general
<spi-devel-general@lists.sourceforge.net>,
I am waiting for David B. to comment/apply it. If you want to see this
in 2.6.25 I suggest you remind 'David Brownell' <david-b@pacbell.net>
Jocke
On Mon, 2008-03-31 at 08:04 -0500, Mike Hench wrote:
> dont write SPMODE reg unless mode changed.
> it causes SPI to go hi-z momentarily
> which can cause a spike on the CLK line
> this is a problem in MMC where /CS is held asserted
> across multiple transactions.
>=20
> Signed-off-by: Mike Hench <mhench@elutions.com>
>=20
> ---
>=20
> --- linux-2.6.25-rc5.orig/drivers/spi/spi_mpc83xx.c 2008-03-10
> 00:22:27.000000000 -0500
> +++ linux-2.6.25-rc5/drivers/spi/spi_mpc83xx.c 2008-03-31
> 07:37:37.000000000 -0500
> @@ -147,6 +147,7 @@
> =20
> if (value =3D=3D BITBANG_CS_ACTIVE) {
> u32 regval =3D
> mpc83xx_spi_read_reg(&mpc83xx_spi->base->mode);
> + u32 regval0 =3D regval;
> u32 len =3D spi->bits_per_word;
> u8 pm;
> =20
> @@ -188,9 +189,16 @@
> regval |=3D SPMODE_PM(pm);
> }
> =20
> - /* Turn off SPI unit prior changing mode */
> - mpc83xx_spi_write_reg(&mpc83xx_spi->base->mode, 0);
> - mpc83xx_spi_write_reg(&mpc83xx_spi->base->mode, regval);
> + // dont write reg unless mode changed.
> + // it causes SPI to go hi-z momentarily
> + // which can cause a spike on the CLK line
> + // this is a problem in MMC where /CS is held asserted
> + // across multiple transactions.
> + if(regval !=3D regval0) {
> + /* Turn off SPI unit prior changing mode */
> + mpc83xx_spi_write_reg(&mpc83xx_spi->base->mode,
> 0);
> + mpc83xx_spi_write_reg(&mpc83xx_spi->base->mode,
> regval);
> + }
> if (mpc83xx_spi->activate_cs)
> mpc83xx_spi->activate_cs(spi->chip_select, pol);
> }
>=20
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>=20
>=20
prev parent reply other threads:[~2008-03-31 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 13:04 [PATCH] mpc83xx SPI glitch Mike Hench
2008-03-31 13:23 ` Joakim Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206969829.7589.463.camel@gentoo-jocke.transmode.se \
--to=joakim.tjernlund@transmode.se \
--cc=linuxppc-dev@ozlabs.org \
--cc=mhench@engagenet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox