From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.183]) by ozlabs.org (Postfix) with ESMTP id 37A2CDE1D1 for ; Tue, 1 Apr 2008 13:15:38 +1000 (EST) Received: by py-out-1112.google.com with SMTP id z59so1987193pyg.27 for ; Mon, 31 Mar 2008 20:15:37 -0700 (PDT) Subject: Re: [PATCH] Add idle power save for ppc 4xx From: Josh Boyer To: michael@ellerman.id.au In-Reply-To: <1207011862.7490.5.camel@concordia.ozlabs.ibm.com> References: <10aea37177130bbe5de7.1206969157@thinkpadL> <1206983237.12155.60.camel@vader.jdub.homelinux.org> <20080331130518.2a6b0264@zod.rchland.ibm.com> <1206987598.9165.10.camel@thinkpadL> <1207011862.7490.5.camel@concordia.ozlabs.ibm.com> Content-Type: text/plain Date: Mon, 31 Mar 2008 22:15:32 -0500 Message-Id: <1207019732.12155.81.camel@vader.jdub.homelinux.org> Mime-Version: 1.0 Cc: kvm-ppc-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote: > > > > I'm assuming you pass a dtb to the virtual guest when you start it up. > > > > Could you define a property in the CPU node there that can be parsed to > > > > use the power_save function instead of always making it the default? > > > > > > Actually, you probably don't want this as a property in the device > > > tree. It doesn't describe hardware. A Kconfig option might be > > > warranted though. > > > > I'll go with the Kconfig option. > > Go with a device-tree check. The pseries kernel supports both bare-metal > and hypervisor in the same kernel image, and it works out which it's > running on by looking at the device-tree. This seems equivalent to me? After some back and forth on IRC, we decided on that as well. I love being right, then wrong, then right again. /me needs more sleep. josh