From: Benjamin Herrenschmidt <benh@ozlabs.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth
Date: Thu, 10 Apr 2008 07:03:22 +1000 [thread overview]
Message-ID: <1207775002.9079.25.camel@pasglop> (raw)
In-Reply-To: <20080409083616.GA24712@lst.de>
On Wed, 2008-04-09 at 10:36 +0200, Christoph Hellwig wrote:
> On Wed, Apr 09, 2008 at 05:21:34PM +1000, Benjamin Herrenschmidt wrote:
> > The iSeries veth driver uses an on-stack struct completion that
> > it initializes using the COMPLETION_INITIALIZER instead of
> > COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
> > lockdep.
>
> should probably go in ASAP independent of the lockdep series.
I don't think there's any difference between the _ONSTACK variant
and the normal one without lockdep, is there ?
Cheers,
Ben.
next prev parent reply other threads:[~2008-04-09 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-09 7:21 [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth Benjamin Herrenschmidt
2008-04-09 8:36 ` Christoph Hellwig
2008-04-09 21:03 ` Benjamin Herrenschmidt [this message]
2008-04-10 10:56 ` Christoph Hellwig
2008-04-10 12:21 ` Benjamin Herrenschmidt
2008-04-09 8:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207775002.9079.25.camel@pasglop \
--to=benh@ozlabs.org \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).