From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2.6.26?] Raise the upper limit of NR_CPUS.
Date: Mon, 21 Apr 2008 19:24:14 +1000 [thread overview]
Message-ID: <1208769854.9640.24.camel@pasglop> (raw)
In-Reply-To: <1208768706.9955.9.camel@concordia>
On Mon, 2008-04-21 at 19:05 +1000, Michael Ellerman wrote:
>
> Tony, you should NAK Ben tomorrow after lunch if you know what I
> mean :)
Should I hide ? :-)
> > You must NEVER manipulate kernel globals from prom_init.c. The fact
> that
> > prom_init is linked with the kernel is an "accident" which may
> change.
>
> A very long running accident, we should really look at fixing it some
> time.
Patch welcome :-)
Historically, it used to manipulate some kernel data structures, but we
fixed all of that when we introduced the flat DT model.
> > Your scheme would break among others with kexec or non-OF
> bootloaders
>
> I talked to Tony about it this morning and we came up with a scheme
> that
> should work for all cases.
Excellent.
Cheers,
Ben.
prev parent reply other threads:[~2008-04-21 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 5:33 [PATCH 2.6.26?] Raise the upper limit of NR_CPUS Tony Breeds
2008-04-18 10:33 ` Michael Ellerman
2008-04-21 1:41 ` Tony Breeds
2008-04-21 2:03 ` Benjamin Herrenschmidt
2008-04-21 9:05 ` Michael Ellerman
2008-04-21 9:24 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208769854.9640.24.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).