From: David Woodhouse <dwmw2@infradead.org>
To: Li Yang <leoli@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] MTD: fix partition scan control logic in physmap_of and fsl_elbc_nand
Date: Tue, 22 Apr 2008 19:49:22 +0100 [thread overview]
Message-ID: <1208890162.9212.646.camel@pmac.infradead.org> (raw)
In-Reply-To: <1204201051-13107-1-git-send-email-leoli@freescale.com>
On Thu, 2008-02-28 at 20:17 +0800, Li Yang wrote:
> The generic rule for partition scan is to try all supported
> partition types before an usable partition table is found.
> However the original code returns unsuccessful when there is
> an error in any of the partition types.
>
> Signed-off-by: Li Yang <leoli@freescale.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> I later found that Stefan has proposed a similar patch for physmap_of
> and Peter proposed another patch to fix cmdlinepart instead.
> I'd say that even after cmdlinepart patch is applied the scan control
> logic still needs to be fixed.
I'm not convinced. I think the partition code should return an error if
it hits a hard error, like a failure to read from the device. And return
zero when it doesn't find anything.
--
dwmw2
next prev parent reply other threads:[~2008-04-22 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 12:17 [PATCH] MTD: fix partition scan control logic in physmap_of and fsl_elbc_nand Li Yang
2008-04-22 18:49 ` David Woodhouse [this message]
2008-04-25 11:09 ` [PATCH] MTD: fix partition scan control logic in physmap_ofand fsl_elbc_nand Li Yang
2008-04-28 18:13 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208890162.9212.646.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=leoli@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).