From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 436E1DE09B for ; Wed, 23 Apr 2008 04:49:31 +1000 (EST) Subject: Re: [PATCH] MTD: fix partition scan control logic in physmap_of and fsl_elbc_nand From: David Woodhouse To: Li Yang In-Reply-To: <1204201051-13107-1-git-send-email-leoli@freescale.com> References: <1204201051-13107-1-git-send-email-leoli@freescale.com> Content-Type: text/plain Date: Tue, 22 Apr 2008 19:49:22 +0100 Message-Id: <1208890162.9212.646.camel@pmac.infradead.org> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Stefan Roese , linux-mtd@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2008-02-28 at 20:17 +0800, Li Yang wrote: > The generic rule for partition scan is to try all supported > partition types before an usable partition table is found. > However the original code returns unsuccessful when there is > an error in any of the partition types. > > Signed-off-by: Li Yang > Cc: Stefan Roese > Cc: Peter Korsgaard > --- > I later found that Stefan has proposed a similar patch for physmap_of > and Peter proposed another patch to fix cmdlinepart instead. > I'd say that even after cmdlinepart patch is applied the scan control > logic still needs to be fixed. I'm not convinced. I think the partition code should return an error if it hits a hard error, like a failure to read from the device. And return zero when it doesn't find anything. -- dwmw2