From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Markus Brunner <super.firetwister@googlemail.com>
Cc: netdev@vger.kernel.org, ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: Phy read timeout in ibm_new_emac driver
Date: Wed, 23 Apr 2008 15:18:48 +1000 [thread overview]
Message-ID: <1208927928.9060.18.camel@pasglop> (raw)
In-Reply-To: <200804230706.32641.super.firetwister@gmail.com>
On Wed, 2008-04-23 at 07:06 +0200, Markus Brunner wrote:
> On Wednesday 16 April 2008, Benjamin Herrenschmidt wrote:
>
> > Somebody knows off hand what the standard says the timeout should be ?
>
> Anyone?
>
> I didn't find any documentation on the standard, but I had a look at other
> drivers.
> au1000_eth.c waits 20 ms (20 * 1ms) in mdio_read.
> bfin_mac.c waits 500 * 1us in mdio_poll.
> In both functions the last delay before the timeout is useless, like in
> new_emac. Not nice, but timeouts shouldn't occur anyway.
>
> new emac probably doesn't wait long enough, but 20ms seems to be a bit too
> long.
I just send Jeff a patch doubling the timeouts.
Cheers,
Ben.
prev parent reply other threads:[~2008-04-23 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 10:49 Phy read timeout in ibm_new_emac driver M B
2008-04-16 12:09 ` Benjamin Herrenschmidt
2008-04-23 5:06 ` Markus Brunner
2008-04-23 5:18 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208927928.9060.18.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=super.firetwister@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).