From: Michael Ellerman <michael@ellerman.id.au>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/3 v3] Raise the upper limit of NR_CPUS.
Date: Wed, 23 Apr 2008 15:41:39 +1000 [thread overview]
Message-ID: <1208929299.9212.4.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <d54206d25b690c9160401f65a583f586004dcd5d.1208923391.git.tony@bakeyournoodle.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Wed, 2008-04-23 at 14:06 +1000, Tony Breeds wrote:
> As the pacas are statically initialised increasing NR_CPUS beyond 128,
> means that any additional pacas will be empty ... which is bad.
>
> This patch adds the required functionality to fill in any excess pacas
> at runtime.
>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
You add about 30 lines of code in this patch, which you remove in patch
3, is there a better way to do it?
Is there any harm dynamically initialising the statically initialised
pacas, I think that would allow you to basically skip the
NR_STATIC_PACAS business.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-04-23 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 4:06 [PATCH 1/3 v3] Raise the upper limit of NR_CPUS Tony Breeds
2008-04-23 4:06 ` [PATCH 3/3 v3] Move the paca array into the BSS Tony Breeds
2008-04-23 4:06 ` [PATCH 2/3 v3] Make iSeries spin on __secondary_hold_spinloop, like pSeries Tony Breeds
2008-04-23 5:41 ` Michael Ellerman [this message]
2008-04-23 6:08 ` [PATCH 1/3 v3] Raise the upper limit of NR_CPUS Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208929299.9212.4.camel@concordia.ozlabs.ibm.com \
--to=michael@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox