linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 02/11] Add udbg_console_anytime() which sets udbg console to CON_ANYTIME
Date: Wed, 23 Apr 2008 05:43:23 +0000	[thread overview]
Message-ID: <1208929403.9212.7.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <1208506858.6958.404.camel@pasglop>

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On Fri, 2008-04-18 at 18:20 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2008-04-18 at 17:54 +1000, Michael Ellerman wrote:
> > In theory the udbg console should be safe to call basically at any time
> > after boot. It does not need any per-cpu resources or for the cpu to be
> > online, as long as there is a udbg_putc routine hooked up it should
> > work. So it should be able to be marked as CON_ANYTIME.
> > 
> > Verifying this will take a bit of time and testing though, so instead of
> > marking udbg console as CON_ANYTIME for all platforms, add a routine so
> > that a platform can opt-in to having udbg console called early.
> > 
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> 
> Nah, just stick it always.

Meh, OK. I'm still going to require the platform code to call
register_early_udbg_console() if it wants to register earlier than
setup_system() - so the behaviour will essentially be the same.

NB that if it breaks anything I can now say BenH told me to do it ;)

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-04-23  5:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18  7:54 [PATCH 01/11] Set udbg_console index to 0 Michael Ellerman
2008-04-18  7:54 ` [PATCH 02/11] Add udbg_console_anytime() which sets udbg console to CON_ANYTIME Michael Ellerman
2008-04-18  8:20   ` Benjamin Herrenschmidt
2008-04-23  5:43     ` Michael Ellerman [this message]
2008-04-18  7:54 ` [PATCH 03/11] Register udbg console early on pseries LPAR Michael Ellerman
2008-04-18  7:54 ` [PATCH 04/11] Convert from DBG() to pr_debug() in platforms/pseries/setup.c Michael Ellerman
2008-04-22 13:31   ` Olof Johansson
2008-04-23  5:45     ` Michael Ellerman
2008-04-18  7:54 ` [PATCH 05/11] Convert from DBG() to pr_debug() in platforms/pseries/smp.c Michael Ellerman
2008-04-18  7:54 ` [PATCH 06/11] Convert from DBG() to pr_debug() in platforms/pseries/firmware.c Michael Ellerman
2008-04-18  7:54 ` [PATCH 07/11] Convert from DBG() to pr_debug() in platforms/pseries/iommu.c Michael Ellerman
2008-04-18  7:54 ` [PATCH 08/11] Convert from DBG() to pr_debug() in platforms/pseries/lpar.c Michael Ellerman
2008-04-18  7:54 ` [PATCH 09/11] Convert from DEBUG() to pr_debug() in platforms/pseries/rtasd.c Michael Ellerman
2008-04-18  7:54 ` [PATCH 10/11] Convert from DEBUG() to pr_debug() in platforms/pseries/scanlog.c Michael Ellerman
2008-04-18  7:54 ` [PATCH 11/11] Add CONFIG_PPC_PSERIES_DEBUG to enable debugging for platforms/pseries Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1208929403.9212.7.camel@concordia.ozlabs.ibm.com \
    --to=michael@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).