From: Michael Ellerman <michael@ellerman.id.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Kumar Gala <kumar.gala@freescale.com>,
Jin Zhengxiong <Jason.Jin@freescale.com>
Subject: Re: [PATCH 1/3] MSI driver for Freescale 83xx/85xx/86xx cpu
Date: Wed, 23 Apr 2008 15:45:45 +1000 [thread overview]
Message-ID: <1208929545.9212.12.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <e642c15622ac3ca89a6a43f439f2c222@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On Tue, 2008-04-22 at 15:22 +0200, Segher Boessenkool wrote:
> >>>> +static void fsl_compose_msi_msg(struct pci_dev *pdev, int hwirq,
> >>>> + struct msi_msg *msg)
>
> > No I mean I'm confused about the maths here. If we pull out the
> > variables it boils down to:
> >
> > data = ((hwirq / 32) << 5) | ((hwirq % 32) & 0x1F)
> >
> > Which doesn't seem to actually do anything?
>
> It's not a no-op, because hwirq is signed. It probably should be
> unsigned, like most things.
You'll have to draw me a picture.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-04-23 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 9:27 [PATCH 1/3] MSI driver for Freescale 83xx/85xx/86xx cpu Jason Jin
[not found] ` <1208597267-30960-2-git-send-email-Jason.jin@freescale.com>
2008-04-19 9:27 ` [PATCH 3/3] Enable MSI support for 85xxds board Jason Jin
2008-04-18 11:51 ` Segher Boessenkool
2008-04-21 6:21 ` [PATCH 1/3] MSI driver for Freescale 83xx/85xx/86xx cpu Michael Ellerman
2008-04-21 10:01 ` Jin Zhengxiong
2008-04-22 4:35 ` Michael Ellerman
2008-04-22 5:15 ` Jin Zhengxiong
2008-04-22 13:22 ` Segher Boessenkool
2008-04-23 5:45 ` Michael Ellerman [this message]
2008-04-23 16:05 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208929545.9212.12.camel@concordia.ozlabs.ibm.com \
--to=michael@ellerman.id.au \
--cc=Jason.Jin@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).