From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Michel Dänzer" <michel@tungstengraphics.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
Hollis Blanchard <hollisb@us.ibm.com>,
adaplas@gmail.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Detlev Zundel <dzu@denx.de>
Subject: Re: [Linux-fbdev-devel] [PATCH 1/3] radeonfb: Fix 64 bits resources on 32 bits archs
Date: Wed, 23 Apr 2008 19:40:33 +1000 [thread overview]
Message-ID: <1208943633.9060.26.camel@pasglop> (raw)
In-Reply-To: <1208943127.5632.324.camel@thor.sulgenrain.local>
On Wed, 2008-04-23 at 11:32 +0200, Michel Dänzer wrote:
> > X is doing a mmap of /dev/mem instead of /dev/fb ?
> >
> > You can normally map the fb mapping /dev/fb and then map the
> registers
> > using /dev/fb at an offset beyond the framebuffer (fix->smem_len).
> >
> > If X is using /dev/mem instead, then it's being stupid and needs to
> be
> > fixed...
>
> It's up to the driver, and again, the current radeon driver doesn't
> use
> radeonfb at all anymore...
Right. And I'm happy to go fix what remains, don't get me wrong here :-)
We all know how stupid legacy code can be !
I'll try to get some patches to expose a new version of the structure
sometimes in the upcoming week or two (we'll see what time permits) and
then see about fixing X drivers that need fixing, though hopefully with
pci-rework being upstream now, that shouldn't be many.
The main issue is directfb. I hope they'll catch up with the new ioctls.
Ben.
next prev parent reply other threads:[~2008-04-23 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 1:26 [PATCH 1/3] radeonfb: Fix 64 bits resources on 32 bits archs Benjamin Herrenschmidt
2008-04-22 15:55 ` Christian Ehrhardt
2008-04-22 16:04 ` Michel Dänzer
2008-04-22 22:21 ` Benjamin Herrenschmidt
2008-04-23 9:32 ` [Linux-fbdev-devel] " Michel Dänzer
2008-04-23 9:40 ` Benjamin Herrenschmidt [this message]
2008-04-23 9:57 ` David Miller
2008-04-23 10:34 ` Benjamin Herrenschmidt
2009-01-08 10:20 ` Sergei Shtylyov
2009-01-08 10:26 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208943633.9060.26.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dzu@denx.de \
--cc=hollisb@us.ibm.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michel@tungstengraphics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).