From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Paul Mackerras <paulus@samba.org>,
ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: new warnings from stacktrace patch
Date: Thu, 24 Apr 2008 10:44:21 +1000 [thread overview]
Message-ID: <1208997861.9060.79.camel@pasglop> (raw)
In-Reply-To: <20080423143229.GA18667@lst.de>
On Wed, 2008-04-23 at 16:32 +0200, Christoph Hellwig wrote:
> On Wed, Apr 23, 2008 at 05:59:38PM +1000, Stephen Rothwell wrote:
> > This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
> > Stacktrace support for lockdep"). We don't include asm-offsets.h in any
> > other C file in the powerpc build.
>
> I think the include can be safely removed.
Yup. It's a leftover from before I fixed up some stuff in ptrace.h
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Ack.
> Index: linux-2.6/arch/powerpc/kernel/stacktrace.c
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:05.000000000 +0200
> +++ linux-2.6/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:16.000000000 +0200
> @@ -13,7 +13,6 @@
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> #include <asm/ptrace.h>
> -#include <asm/asm-offsets.h>
>
> /*
> * Save stack-backtrace addresses into a stack_trace buffer.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2008-04-24 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 7:59 new warnings from stacktrace patch Stephen Rothwell
2008-04-23 14:32 ` Christoph Hellwig
2008-04-24 0:44 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208997861.9060.79.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).