new warnings from stacktrace patch

new warnings from stacktrace patch

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

Hi all,

Linus' kernel today produces these warnings for an allyesconfig build:
(it was actually a linux-next build, but the commit is in Linus' tree)

In file included from arch/powerpc/kernel/stacktrace.c:16:
include/asm/asm-offsets.h:113:1: warning: "CLONE_VM" redefined
In file included from arch/powerpc/kernel/stacktrace.c:13:
include/linux/sched.h:8:1: warning: this is the location of the previous definition
In file included from arch/powerpc/kernel/stacktrace.c:16:
include/asm/asm-offsets.h:114:1: warning: "CLONE_UNTRACED" redefined
In file included from arch/powerpc/kernel/stacktrace.c:13:
include/linux/sched.h:22:1: warning: this is the location of the previous definition
In file included from arch/powerpc/kernel/stacktrace.c:16:
include/asm/asm-offsets.h:151:1: warning: "NSEC_PER_SEC" redefined
In file included from include/linux/timex.h:57,
                 from include/linux/sched.h:54,
                 from arch/powerpc/kernel/stacktrace.c:13:
include/linux/time.h:37:1: warning: this is the location of the previous definition

This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
Stacktrace support for lockdep").  We don't include asm-offsets.h in any
other C file in the powerpc build.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: new warnings from stacktrace patch

[Christoph Hellwig]

On Wed, Apr 23, 2008 at 05:59:38PM +1000, Stephen Rothwell wrote:
> This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
> Stacktrace support for lockdep").  We don't include asm-offsets.h in any
> other C file in the powerpc build.

I think the include can be safely removed.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/arch/powerpc/kernel/stacktrace.c
===================================================================
--- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c	2008-04-23 15:28:05.000000000 +0200
+++ linux-2.6/arch/powerpc/kernel/stacktrace.c	2008-04-23 15:28:16.000000000 +0200
@@ -13,7 +13,6 @@
 #include <linux/sched.h>
 #include <linux/stacktrace.h>
 #include <asm/ptrace.h>
-#include <asm/asm-offsets.h>
 
 /*
  * Save stack-backtrace addresses into a stack_trace buffer.

Re: new warnings from stacktrace patch

[Benjamin Herrenschmidt]

On Wed, 2008-04-23 at 16:32 +0200, Christoph Hellwig wrote:
> On Wed, Apr 23, 2008 at 05:59:38PM +1000, Stephen Rothwell wrote:
> > This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
> > Stacktrace support for lockdep").  We don't include asm-offsets.h in any
> > other C file in the powerpc build.
> 
> I think the include can be safely removed.

Yup. It's a leftover from before I fixed up some stuff in ptrace.h

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Ack.

> Index: linux-2.6/arch/powerpc/kernel/stacktrace.c
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c	2008-04-23 15:28:05.000000000 +0200
> +++ linux-2.6/arch/powerpc/kernel/stacktrace.c	2008-04-23 15:28:16.000000000 +0200
> @@ -13,7 +13,6 @@
>  #include <linux/sched.h>
>  #include <linux/stacktrace.h>
>  #include <asm/ptrace.h>
> -#include <asm/asm-offsets.h>
>  
>  /*
>   * Save stack-backtrace addresses into a stack_trace buffer.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev