linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC][WIP][PATCH] Add IRQSTACKS to ppc32
Date: Thu, 24 Apr 2008 17:18:57 +1000	[thread overview]
Message-ID: <1209021537.9060.156.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.0804240034160.23185@blarg.am.freescale.net>


On Thu, 2008-04-24 at 00:37 -0500, Kumar Gala wrote:
> +       /*
> +        * interrupt stacks must be under 256MB, we cannot afford to
> take
> +        * SLB misses on them.
> +        */
> +       for_each_possible_cpu(i) {
> +               softirq_ctx[i] = (struct thread_info *)
> +                       __va(lmb_alloc_base(THREAD_SIZE,
> +                                           THREAD_SIZE, 0x10000000));
> +               hardirq_ctx[i] = (struct thread_info *)
> +                       __va(lmb_alloc_base(THREAD_SIZE,
> +                                           THREAD_SIZE, 0x10000000));
> +       }
> +

The comment is a bit bogus :-) (about SLB misses). lowmem is your limit
I think. Also, why not share the code with ppc64 ?

Ben.

  reply	other threads:[~2008-04-24  7:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24  5:37 [RFC][WIP][PATCH] Add IRQSTACKS to ppc32 Kumar Gala
2008-04-24  7:18 ` Benjamin Herrenschmidt [this message]
2008-04-24 12:59   ` Kumar Gala
2008-04-24 14:53     ` Benjamin Herrenschmidt
2008-04-24 16:25       ` Kumar Gala
2008-04-25  7:23 ` Christoph Hellwig
2008-04-25 13:03   ` Benjamin Herrenschmidt
2008-04-25 13:37     ` Kumar Gala
2008-04-25 22:56       ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209021537.9060.156.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).