Re: mpc5200b custom board upstreamable?

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Thu, 2008-04-24 at 18:28 +0200, Sascha Hauer wrote:
> 
> At the moment my compatible entry looks like this:
> 
> compatible = "phytec,pcm030","generic-mpc52xx";
> 
> What I think would be nice is that "phytec,pcm030" support is used
> when available and "generic-mpc52xx" as a fallback. We do not have any
> platform specific hacks at the moment, but we may have later. Having
> "phytec,pcm030" in the simple machine would prevent us from doing so.

No, please avoid that 'generic' stuff for now, for all the good reasons
Grant gave. It might be nice but we aren't there yet. It's trivial to
add phytec,pcm030 to the list we support and use that for now.

If you do a rev tomorrow that is still compatible and in fact is very
close to the pcm030 programmatically and call it pcm035, then you could
do something like

compatible = "phytec,pcm035", "phytec,pcm030".

But don't toy with "generic" things, they sound like good ideas but they
ultimately come back and bite us.

Cheers,
Ben.