From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bill Fink <billfink@mindspring.com>
Cc: super.firetwister@googlemail.com, netdev@vger.kernel.org,
jgarzik@pobox.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: Increase MDIO timeouts
Date: Sat, 26 Apr 2008 08:22:38 +1000 [thread overview]
Message-ID: <1209162158.5420.35.camel@pasglop> (raw)
In-Reply-To: <20080425165703.864e63bd.billfink@mindspring.com>
On Fri, 2008-04-25 at 16:57 -0400, Bill Fink wrote:
> On Wed, 23 Apr 2008, Benjamin Herrenschmidt wrote:
>
> > This patch doubles the MDIO timeouts in EMAC as there are field
> > cases where they are two short to communicate with some PHYs.
>
> I guess them being "two short" is why they needed to be doubled. :-)
Well, in that case, it makes sense, it's still pretty short and better
safe than sorry. On day I may look at actually measuring PHYs and see if
it's worth trying to do sleeping waits in there.
Ben.
next prev parent reply other threads:[~2008-04-25 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 5:17 [PATCH] ibm_newemac: Increase MDIO timeouts Benjamin Herrenschmidt
2008-04-25 6:04 ` Jeff Garzik
2008-04-25 20:57 ` Bill Fink
2008-04-25 22:22 ` Benjamin Herrenschmidt [this message]
2008-04-25 23:58 ` Josh Boyer
2008-04-26 3:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209162158.5420.35.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=billfink@mindspring.com \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=super.firetwister@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).