From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [patch 1/5] POWERPC: Fix slb.c compile warnings
Date: Thu, 01 May 2008 09:01:41 +1000 [thread overview]
Message-ID: <1209596501.18023.260.camel@pasglop> (raw)
In-Reply-To: <4818F1BA.80408@am.sony.com>
On Wed, 2008-04-30 at 15:24 -0700, Geoff Levand wrote:
> Arrange for a syntax check to always be done on the powerpc/mm/slb.c
> DBG() macro by defining it to pr_debug() for non-debug builds.
>
> Also, fix these related compile warnings:
>
> slb.c:273: warning: format '%04x' expects type 'unsigned int', but argument 2 has type 'long unsigned int
> slb.c:274: warning: format '%04x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/mm/slb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/arch/powerpc/mm/slb.c
> +++ b/arch/powerpc/mm/slb.c
> @@ -30,7 +30,7 @@
> #ifdef DEBUG
> #define DBG(fmt...) udbg_printf(fmt)
> #else
> -#define DBG(fmt...)
> +#define DBG pr_debug
> #endif
>
> extern void slb_allocate_realmode(unsigned long ea);
> @@ -279,8 +279,8 @@ void slb_initialize(void)
> patch_slb_encoding(slb_compare_rr_to_size,
> mmu_slb_size);
>
> - DBG("SLB: linear LLP = %04x\n", linear_llp);
> - DBG("SLB: io LLP = %04x\n", io_llp);
> + DBG("SLB: linear LLP = %04lx\n", linear_llp);
> + DBG("SLB: io LLP = %04lx\n", io_llp);
> }
>
> get_paca()->stab_rr = SLB_NUM_BOLTED;
>
next prev parent reply other threads:[~2008-04-30 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080430215644.655638516@am.sony.com>
2008-04-30 22:24 ` [patch 1/5] POWERPC: Fix slb.c compile warnings Geoff Levand
2008-04-30 23:01 ` Benjamin Herrenschmidt [this message]
2008-04-30 22:25 ` [patch 2/5] PS3: Add time include to lpm Geoff Levand
2008-05-01 2:33 ` FUJITA Tomonori
2008-04-30 22:25 ` [patch 3/5] PS3: Make ps3_virq_setup and ps3_virq_destroy static Geoff Levand
2008-04-30 22:25 ` [patch 4/5] PS3: Remove unsupported wakeup sources Geoff Levand
2008-04-30 22:25 ` [patch 5/5] PS3: Update ps3_defconfig Geoff Levand
2008-05-02 13:45 ` Marvin
2008-05-05 19:00 ` Geoff Levand
2008-05-06 8:14 ` Marvin
2008-05-06 9:44 ` [Cbe-oss-dev] Xorg crash when PCI not enabled (was [patch 5/5] PS3: Update ps3_defconfig) Dan Munckton
2008-05-06 16:01 ` [Cbe-oss-dev] Xorg crash when PCI not enabled Marvin
2008-05-06 10:51 ` [patch 5/5] PS3: Update ps3_defconfig Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209596501.18023.260.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).