From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [POWERPC][v2] Bolt in SLB entry for kernel stack on secondary cpus
Date: Sat, 03 May 2008 09:19:43 +1000 [thread overview]
Message-ID: <1209770383.26383.5.camel@pasglop> (raw)
In-Reply-To: <18458.55542.977597.204532@cargo.ozlabs.ibm.com>
On Fri, 2008-05-02 at 19:03 +1000, Paul Mackerras wrote:
> David Gibson writes:
>
> > Do you even need the processor ID test at all? The boot processor
> > should always have its stack covered by SLB entry 0 when we come
> > through here, shouldn't it?
>
> I was concerned that get_paca()->kstack wouldn't have been initialized
> by the time the boot cpu calls slb_initialize(). If that fear is
> unfounded then the check could go.
No, you are correct, it's not initialized. However, I find that a bit
weird, as we shouldn't have a problem initializing it in
start_here_multiplatform rather than start_here_common.
The whole stack setup part of these here seems like a dup to me.
Ben.
prev parent reply other threads:[~2008-05-02 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 4:29 [POWERPC][v2] Bolt in SLB entry for kernel stack on secondary cpus Paul Mackerras
2008-05-02 5:56 ` David Gibson
2008-05-02 9:03 ` Paul Mackerras
2008-05-02 23:19 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209770383.26383.5.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).