linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Fix bootwrapper builds with newer gcc versions
Date: Sat, 03 May 2008 09:27:55 +1000	[thread overview]
Message-ID: <1209770875.26383.14.camel@pasglop> (raw)
In-Reply-To: <20080502.144009.147804001.davem@davemloft.net>


On Fri, 2008-05-02 at 14:40 -0700, David Miller wrote:
> From: Kumar Gala <galak@kernel.crashing.org>
> Date: Fri, 2 May 2008 16:28:36 -0500
> 
> > Sorry, I meant the gcc patch.  I'm not sure if this has been committed  
> > to FSF head or not.
> 
> If that's the case it would be a good idea to suggest a command line
> option to disable the new out-of-line code generation feature of that
> patch.
> 
> But if the stubs it calls are really simple, you can just add
> implementations under arch/powerpc/lib/, and therefore it's
> not such a big deal.  This is what we've traditionally done
> with libcalls generated by gcc for runtime support.

My only worry with this is modules.

That is, it would be fairly non-sensical for module code to go through
the trampoline to call those stubs in the kernel (and having to
EXPORT_SYMBOL them).

In the case of those register save stubs, I believe they should really
be linked with the modules.

Ben.

  parent reply	other threads:[~2008-05-02 23:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02  8:11 [PATCH] [POWERPC] Fix bootwrapper builds with newer gcc versions Kumar Gala
2008-05-02 11:54 ` Segher Boessenkool
2008-05-02 13:28   ` Kumar Gala
2008-05-02 13:37     ` Segher Boessenkool
2008-05-02 13:41       ` Kumar Gala
2008-05-02 15:20         ` Scott Wood
2008-05-02 17:15         ` Segher Boessenkool
2008-05-02 14:09   ` Kumar Gala
2008-05-02 17:11     ` Segher Boessenkool
2008-05-02 21:28       ` Kumar Gala
2008-05-02 21:40         ` David Miller
2008-05-02 21:58           ` Kumar Gala
2008-05-02 23:27           ` Benjamin Herrenschmidt [this message]
2008-05-02 23:38             ` David Miller
2008-05-03  0:06               ` Segher Boessenkool
2008-05-03  7:50               ` Benjamin Herrenschmidt
2008-05-03  7:55                 ` David Miller
2008-05-03 11:01                   ` Benjamin Herrenschmidt
2008-05-05 11:55                   ` Gabriel Paubert
2008-05-02 12:13 ` Josh Boyer
2008-05-02 13:32   ` Kumar Gala
2008-05-02 13:53     ` Josh Boyer
2008-05-02 13:59       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209770875.26383.14.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).