From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C7C59DDF19 for ; Sat, 3 May 2008 09:28:04 +1000 (EST) Subject: Re: [PATCH] [POWERPC] Fix bootwrapper builds with newer gcc versions From: Benjamin Herrenschmidt To: David Miller In-Reply-To: <20080502.144009.147804001.davem@davemloft.net> References: <8CB3566C-F433-4457-906D-247BBB8D5505@kernel.crashing.org> <56cafb8cfeb954984d6e400c3de789b8@kernel.crashing.org> <3B083683-CB6E-4F1D-87EF-BBFA7D491271@kernel.crashing.org> <20080502.144009.147804001.davem@davemloft.net> Content-Type: text/plain Date: Sat, 03 May 2008 09:27:55 +1000 Message-Id: <1209770875.26383.14.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2008-05-02 at 14:40 -0700, David Miller wrote: > From: Kumar Gala > Date: Fri, 2 May 2008 16:28:36 -0500 > > > Sorry, I meant the gcc patch. I'm not sure if this has been committed > > to FSF head or not. > > If that's the case it would be a good idea to suggest a command line > option to disable the new out-of-line code generation feature of that > patch. > > But if the stubs it calls are really simple, you can just add > implementations under arch/powerpc/lib/, and therefore it's > not such a big deal. This is what we've traditionally done > with libcalls generated by gcc for runtime support. My only worry with this is modules. That is, it would be fairly non-sensical for module code to go through the trampoline to call those stubs in the kernel (and having to EXPORT_SYMBOL them). In the case of those register save stubs, I believe they should really be linked with the modules. Ben.